Merge pull request #52 from EmilHvitfeldt/printing-bug

Fix printing bug for materialization
r-lib · May 13, 2024 · 9341dd7 · 9341dd7
2 parents 17f163c + 09b3c1b
commit 9341dd7
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/altrep-sparse-double.c b/src/altrep-sparse-double.c
@@ -67,7 +67,7 @@ const void* altrep_sparse_double_Dataptr_or_null(SEXP x) {
   if (out == R_NilValue) {
     return NULL;
   } else {
-    return out;
+    return STDVEC_DATAPTR(out);
   }
 }
 

diff --git a/tests/testthat/_snaps/altrep.md b/tests/testthat/_snaps/altrep.md
@@ -268,3 +268,10 @@
       sparsevctrs: Sparse vector materialized
       [1] 1
 
+# printing works #48
+
+    Code
+      sparse_double(1, 1, 10) + 1
+    Output
+       [1] 2 1 1 1 1 1 1 1 1 1
+
diff --git a/tests/testthat/test-altrep.R b/tests/testthat/test-altrep.R
@@ -444,3 +444,9 @@ test_that("verbose testing", {
   )
 })
 
+test_that("printing works #48", {
+  expect_snapshot(
+    sparse_double(1, 1, 10) + 1
+  )
+})
+