Broken revdeps relating to #2212

[mikemahoney218]

As #2212 added an attribute to sf objects, some reverse dependencies (presumably those testing that an object is identical to a previously-saved sf object) started throwing errors, which led to the attribute being gated behind an environment variable. I'm opening this issue to track what packages are impacted as well as to (hopefully) track updates to those packages that will prevent non-breaking additions to the structure of sf objects from causing errors.

I checked all reverse dependencies against 92b949b , then reverted b978d70 and checked all reverse dependencies again. Only five packages had new problems due to the attribute change:

New problems (5)

package	version	error	warning	note	issue	status
geodimension	1.0.1	+1		1	josesamos/geodimension#3	Fixed on CRAN
h3jsr	1.3.1	+1			obrl-soil/h3jsr#10; obrl-soil/h3jsr#12	Fixed on GitHub
qualmap	0.2.1	+1			chris-prener/qualmap#6; chris-prener/qualmap#7	Fixed on CRAN
riverdist	0.16.1	+1			mbtyers/riverdist#19	Fixed on CRAN
tidytransit	1.6.0	+1		1	r-transit/tidytransit#210	Fixed on CRAN

h3jsr also errors against 92b949b, but gets a new error when the attribute is present.

[edzer]

Great work, very helpful!

[mikemahoney218]

As a bit of an update, I rechecked all the packages my automated script failed on -- all work fine with the new attribute.

That means it's only these five packages, as best as I can tell, that have issues with the new attribute. I've opened issues on each seeing if they're willing to update their tests.

[mikemahoney218]

Quick update here -- a month later, 3/5 packages have pushed a fix to their tests to CRAN, with 1 package being fixed on GitHub (yesterday, so hopefully a CRAN release in the future). The last package, qualmap, hasn't had any activity yet -- I just emailed the maintainer to see if he'd be open to the PR I posted on that page.

I have not re-run revdeps since my initial investigation, so it's entirely possible that there are new problem packages -- I'm honestly surprised this only caused 5 issues. But we're getting close to the original issues being fixed.