Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard navigation to the edit experience #23

Open
nazmulidris opened this issue Oct 9, 2023 · 5 comments
Open

Add keyboard navigation to the edit experience #23

nazmulidris opened this issue Oct 9, 2023 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nazmulidris
Copy link
Member

Currently, in order to edit shortlinks, the user has to use a mouse. It would be great to have a way to use keyboard shortcuts to navigate the entire editing experience.

This could look like:

  • The user types a keyboard shortcut to activate edit mode
  • Then they can press up / down to move focus between the shortlink that is selected
  • Maybe they press Enter and that triggers the edit button, or they press Delete and that triggers the delete button
  • As a bonus, if there was a way to search / filter the shortlinks in edit mode, that would be great too!
@nazmulidris nazmulidris added good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest labels Oct 9, 2023
@shlok-2003
Copy link

Hey @nazmulidris, I would like to work on this issue, Can you please assign it to me :)

@nazmulidris
Copy link
Member Author

Hi 👋🏽 @shlok-2003 , this issue is all yours 👍🏽 . Please take a look at our contributor guide. And we have a discord server if you would like to chat about the issue or PR.

Also, please associate your PR and issue using this technique: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@nazmulidris
Copy link
Member Author

@shlok-2003 Hi 👋🏽 If you don't have time to work on this issue, please let me know and I can assign it to someone else. Thank you for spending your time contributing.

@shlok-2003 shlok-2003 removed their assignment Oct 16, 2023
@postmeback
Copy link

Hi @nazmulidris, Can you tell me how to run this project locally?

@nazmulidris
Copy link
Member Author

@postmeback The instructions are in the README
https://github.com/r3bl-org/shortlink?tab=readme-ov-file#setup

npm install
npm run build
npm run watch

You will find a dist folder on your disk. You can tell Chrome to load an extension from this folder. Here's more info on that: https://developer.chrome.com/docs/extensions/get-started/tutorial/hello-world

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants