[ADHOC] chore(sdk): enable useAwait biome config #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
topocount
force-pushed
the
use-await
branch
3 times, most recently
from
2e53953
to
f359340
Compare
mmackz
reviewed
Sep 19, 2024
topocount
force-pushed
the
use-await
branch
from
f359340
to
ad19150
Compare
sammccord
reviewed
Sep 20, 2024
sammccord
reviewed
Sep 20, 2024
| @@ -119,7 +119,7 @@ describe('EventAction', () => { | |||
| filterType: FilterType.EQUAL, | |||
| fieldType: PrimitiveType.ADDRESS, | |||
| fieldIndex: 2, | |||
| filterData: accounts.at(1)!.account.toUpperCase(), | |||
| filterData: accounts[1].account.toUpperCase(), | |||
There was a problem hiding this comment.
I don't think this refactor solves the core issue which is that the item is potentially undefined. Is the bracket access a preference thing?
There was a problem hiding this comment.
It does because the accounts are fixed-length tuple now
There was a problem hiding this comment.
topocount
force-pushed
the
use-await
branch
2 times, most recently
from
78f7194
to
cb8eecb
Compare
topocount
force-pushed
the
use-await
branch
from
cb8eecb
to
80a7f09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This config ensures awaits are used for async functions within async functions