Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private vs Internal and prepend _ #185

Open
Quazia opened this issue Aug 18, 2023 · 0 comments
Open

Private vs Internal and prepend _ #185

Quazia opened this issue Aug 18, 2023 · 0 comments
Labels
improvement changes that improve the security, or performance of the code without modifying the functionality

Comments

@Quazia
Copy link
Member

Quazia commented Aug 18, 2023

I'd like to standardize to using underscores in internal function names (i.e. createERC20QuestInternal becomes _createERC20Quest) and switch any private functions over to internal unless there's an explicit reasoning behind having them be private.
@Quazia Quazia added the improvement changes that improve the security, or performance of the code without modifying the functionality label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement changes that improve the security, or performance of the code without modifying the functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Quazia