🔨forge: coverage and gas reporting #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynehoover
approved these changes
Aug 21, 2023
|
Is this okay to bring in still? I don't see any reason not to now that there's no HH testing |
|
Oh we're not using any package scripts anymore so I should probably remove that part... |
…into forge_coverage
waynehoover
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure when we'll want to bring this into main, but I doubt this PR will go stale. I left the
hardhatcoverage command and gas reporting here for the time being - although it doesn't look like thehardhat coverageis working right now. Is it worth trying to get that up and running for the migration towardsfoundry? Also want to automate the coverage badge still.closes #178