Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen ip address configuration for management console. #464

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Listen ip address configuration for management console. #464

merged 1 commit into from
Oct 16, 2017

Conversation

dragonsmith
Copy link
Contributor

Hello!

I've recently started using your cookbook for rabbitmq. In my case, all servers have public & private networking simultaneously, and I do not want RabbitMQ to listen on public network or 0.0.0.0 as it does by default.

In your cookbook, you already have attributes(and some hacks):

  • node['rabbitmq']['erl_networking_bind_address']
  • node['rabbitmq']['erl_networking_bind_address']
  • node['rabbitmq']['kernel']['inet_dist_use_interface']

But nothing configures ip address for the management console. And I find it strange. I believe it is a pretty demanded option for many people.

e.g. [#442] is a similar issue, but addresses the problem even more globally.

Thank you very much!

P.S. About the tests. I do not see many tests for rabbitmq.config syntax and contents. I can cover my additions with some tests if you tell me so. Thank you again!

@michaelklishin michaelklishin merged commit 5635b6e into rabbitmq:master Oct 16, 2017
@michaelklishin
Copy link
Member

Thank you!

@michaelklishin
Copy link
Member

@dragonsmith some configuration tests would be appreciated but it might not be the right time to cover the config format this cookbook uses today. As of 3.7.0 a new format will be promoted for most things and this cookbook will undergo a transition. Using the current Erlang term-based format will be possible but unnecessary for most things.

So I suggest that we wait it out.

@dragonsmith
Copy link
Contributor Author

Thank you very much for such a fast response!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants