Fixes for pre-init recovery and handling of gaps in mem tables due to snapshotting #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
changed the title
kjnilsson
force-pushed
the
pre-init-bug-fixes
branch
from
4062585
to
8e2bbf8
Compare
kjnilsson
changed the title
|
tiny typo in the commit message & description: apperas => appears |
The first thing a ra system does when it starts is run a pre-init phase for each registered Ra server, mostly to recover the ra_log_snapshot_state table. This appears to have been broken for along time and the ra_log_snapshot_table has not been populated ahead of WAL / segment writer recovery. This was fine as this bit was just an optimisation and never affected the workings of the Ra infrastructure. However since 5b7a265 it needs this in order to avoid the segment writer crashing when it detects a gap (caused by the WAL dropping entries lower than the current snapshot). This commit mostly fixes the pre-init process but also addresses a potential race condition which still could cause the segment writer to crash for the same reason. maybe de-flake
kjnilsson
force-pushed
the
pre-init-bug-fixes
branch
from
82c4cbc
to
a7ed36e
Compare
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first thing a ra system does when it starts is run a pre-init
phase for each registered Ra server, mostly to recover the
ra_log_snapshot_state table. This appears to have been broken
for along time and the ra_log_snapshot_table has not been populated
ahead of WAL / segment writer recovery. This was fine as this bit
was just an optimisation and never affected the workings of
the Ra infrastructure.
However since 5b7a265 it needs
this in order to avoid the segment writer crashing when it detects
a gap (caused by the WAL dropping entries lower than the current
snapshot).
This commit mostly fixes the pre-init process but also addresses
a potential race condition which still could cause the segment
writer to crash for the same reason.
See: rabbitmq/rabbitmq-server#11712