(WIP) Bump seshat #469
Draft
(WIP) Bump seshat #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit hash should be replaced when a new hex version is cut.
the-mikedavis
force-pushed
the
md/bump-seshat
branch
from
68dfeb8
to
55a4a9c
Compare
This new field sets the `seshat:label()` when creating a new counter for a server (via `ra_counters:new/3` and in turn `seshat:new/4`). This also deprecates the `counter` field. Having the creator of a Ra server pass a `counters:counter_ref()` is unergonomic because the caller must know the `seshat:fields_spec()` with which the counter should be created. Also in this change we remove the call to `ra_counters:new/2` from the `ra_server_proc:config_defaults()` helper. By calling that function when creating a default, the server process registered a counter (causing an insertion into an ETS table in seshat) for the server even if the caller specified a `counter` in the config.
the-mikedavis
force-pushed
the
md/bump-seshat
branch
from
55a4a9c
to
aef7775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion change in Ra for rabbitmq/seshat#12
The changes are:
ra_counters:new/3which wraps the newseshat:new/4allowing the caller to specify aseshat:label()counter_labelto the Ra server config and mutable config which allows specifying thatseshat:label().In RabbitMQ we can use this when creating a Ra config to specify the queue resource for QQs and the Ra cluster and system names for other servers like Khepri and the stream coordinator.