Skip to content

Commit

Permalink
Merge pull request #1748 from rabbitmq/lukebakken/nuget-package-updates
Browse files Browse the repository at this point in the history
Update NuGet packages
  • Loading branch information
lukebakken authored Dec 14, 2024
2 parents 0496126 + 4dca7a0 commit 5b64e27
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 82 deletions.
3 changes: 2 additions & 1 deletion projects/Benchmarks/Benchmarks.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@

<ItemGroup>
<PackageReference Include="BenchmarkDotNet" />
<PackageReference Include="Ductus.FluentDocker" />
<PackageReference Include="System.Collections.Immutable" />
<PackageReference Include="System.Reflection.Metadata" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System;
using System.Text;
using System.Text;
using System.Threading.Tasks;
using BenchmarkDotNet.Attributes;
using RabbitMQ.Client;
Expand All @@ -11,21 +10,8 @@ public class Networking_BasicDeliver
{
private const int messageCount = 10000;

private IDisposable _container;
private static byte[] _body = Encoding.UTF8.GetBytes("hello world");

[GlobalSetup]
public void GlobalSetup()
{
_container = RabbitMQBroker.Start();
}

[GlobalCleanup]
public void GlobalCleanup()
{
_container.Dispose();
}

[Benchmark(Baseline = true)]
public async Task Publish_Hello_World()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System;
using System.Text;
using System.Text;
using System.Threading.Tasks;
using BenchmarkDotNet.Attributes;
using RabbitMQ.Client;
Expand All @@ -9,7 +8,6 @@ namespace Benchmarks.Networking
[MemoryDiagnoser]
public class Networking_BasicDeliver_LongLivedConnection
{
private IDisposable _container;
private IConnection _connection;

private const int messageCount = 10000;
Expand All @@ -18,8 +16,6 @@ public class Networking_BasicDeliver_LongLivedConnection
[GlobalSetup]
public void GlobalSetup()
{
_container = RabbitMQBroker.Start();

var cf = new ConnectionFactory { ConsumerDispatchConcurrency = 2 };
// NOTE: https://github.com/dotnet/BenchmarkDotNet/issues/1738
_connection = EnsureCompleted(cf.CreateConnectionAsync());
Expand All @@ -29,7 +25,6 @@ public void GlobalSetup()
public void GlobalCleanup()
{
_connection.Dispose();
_container.Dispose();
}

[Benchmark(Baseline = true)]
Expand Down
50 changes: 0 additions & 50 deletions projects/Benchmarks/Networking/RabbitMqBroker.cs

This file was deleted.

18 changes: 8 additions & 10 deletions projects/Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="BenchmarkDotNet" Version="0.13.12" />
<PackageVersion Include="Ductus.FluentDocker" Version="2.10.59" />
<PackageVersion Include="BenchmarkDotNet" Version="0.14.0" />
<PackageVersion Include="EasyNetQ.Management.Client" Version="3.0.0" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageVersion Include="Nullable" Version="1.3.1" />
<PackageVersion Include="OpenTelemetry.Api" Version="1.9.0" />
<PackageVersion Include="OpenTelemetry.Exporter.InMemory" Version="1.9.0" />
<PackageVersion Include="System.Collections.Immutable" Version="8.0.0" />
<!--
Note: do NOT upgrade the System.IO.Pipelines dependency unless necessary
See https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1481#pullrequestreview-1847905299
Expand All @@ -19,11 +19,12 @@
<PackageVersion Include="System.Text.Json" Version="8.0.5" />
<PackageVersion Include="System.Text.RegularExpressions" Version="4.3.1" />
<PackageVersion Include="System.Threading.RateLimiting" Version="8.0.0" />
<PackageVersion Include="WireMock.Net" Version="1.5.62" />
<PackageVersion Include="xunit" Version="2.9.0" />
<PackageVersion Include="System.Reflection.Metadata" Version="8.0.0" />
<PackageVersion Include="WireMock.Net" Version="1.6.9" />
<PackageVersion Include="xunit" Version="2.9.2" />
<PackageVersion Include="xunit.abstractions" Version="2.0.3" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" />
<PackageVersion Include="Xunit.SkippableFact" Version="1.4.13" />
<PackageVersion Include="Xunit.SkippableFact" Version="1.5.23" />
</ItemGroup>
<ItemGroup Condition="$(TargetFramework)=='netstandard2.0'">
<!--
Expand All @@ -38,12 +39,9 @@
<PackageVersion Include="System.Net.Http.Json" Version="8.0.1" />
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
<GlobalPackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />
</ItemGroup>
<ItemGroup Condition="'$(IsPackable)'=='true'">
<GlobalPackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4" />
<GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<GlobalPackageReference Include="MinVer" Version="5.0.0" />
<GlobalPackageReference Include="MinVer" Version="6.0.0" />
</ItemGroup>
</Project>

0 comments on commit 5b64e27

Please sign in to comment.