Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CancellationToken to Async members of IChannel #1535

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Add CancellationToken to Async members of IChannel #1535

merged 1 commit into from
Apr 20, 2024

Conversation

lukebakken
Copy link
Contributor

@lukebakken lukebakken commented Apr 17, 2024 •
edited
Loading

@lukebakken lukebakken added this to the 7.0.0 milestone Apr 17, 2024
@lukebakken lukebakken self-assigned this Apr 17, 2024
@lukebakken lukebakken changed the title Add CancellationToken to Async members of IChannel Add CancellationToken to Async members of IChannel Apr 17, 2024
@lukebakken
Add CancellationToken to Async members of IChannel
3df46cc 
* `BasicAckAsync`
* `BasicNackAsync`
* `BasicRejectAsync`
* `BasicCancelAsync`

* Add `CancellationToken` to `BasicPublishAsync`

* Add `CancellationToken` to a couple more places.

* Remove dead code

* Add a few more TODOs for cancellation tokens

* Add cancellation token to `BasicConsumeAsync`

* Add cancellation token to `BasicGetAsync`

* Add cancellation token to `BasicQosAsync`

* Add cancellation token to `CloseAsync`

* Add cancellation token to `ConfirmSelectAsync`

* Add cancellation token to `ExchangeBindAsync`

* Add cancellation token to `ExchangeDeclareAsync` and `ExchangeDeclarePassiveAsync`

* Add cancellation token to `ExchangeDeleteAsync`

* Add cancellation token to `ExchangeUnbindAsync`

* Add cancellation token to remainder of `IChannel`

* Ensure that token source is disposed correctly in async rpc continuations
@lukebakken lukebakken force-pushed the lukebakken/finish-cancellation-token-todos branch from abde277 to 3df46cc Compare April 19, 2024 23:27
@lukebakken lukebakken marked this pull request as ready for review April 20, 2024 02:05
@lukebakken lukebakken merged commit 8cb3f39 into main Apr 20, 2024
11 checks passed
@lukebakken lukebakken deleted the lukebakken/finish-cancellation-token-todos branch April 20, 2024 02:06
@lukebakken lukebakken mentioned this pull request May 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@lukebakken