Skip to content

Commit

Permalink
Merge pull request #45 from rachelsoae/accessibility
Browse files Browse the repository at this point in the history
Accessibility
  • Loading branch information
rachelsoae committed Dec 29, 2023
2 parents 48c3b8e + 7aaa574 commit e41da12
Show file tree
Hide file tree
Showing 11 changed files with 25 additions and 36 deletions.
2 changes: 1 addition & 1 deletion src/components/About/About.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {Link} from 'react-router-dom';
const About = () => {
return (
<div className='about'>
<h2 className='page-header'>About</h2>
<h1 className='page-header'>About</h1>
<div className='about__content'>
<img
className='about__image'
Expand Down
10 changes: 5 additions & 5 deletions src/components/App/_App.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,12 @@ main {
}
}

h2 {
h1 {
@include header-font;
margin: 2em 0;
}

.page-header {
margin: 3rem;
}

p {
Expand Down Expand Up @@ -95,6 +98,3 @@ button:hover,
}
}

.page-header {
margin: 3rem;
}
2 changes: 1 addition & 1 deletion src/components/Contact/Contact.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import github from '../../assets/icons/github.png';
const Contact = () => {
return (
<div className='contact'>
<h2 className='page-header'>Contact</h2>
<h1 className='page-header'>Contact</h1>
<div className='contact__email-container'>
<p>Email me at</p>
<a href='mailto:rachelprather1@gmail.com'>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Home/Home.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const Home = () => {
<div className='hero'>
<div className='hero__text-container'>
<section className='hero__text-wrapper'>
<h2>Software Engineer & Web Developer</h2>
<h1>Software Engineer & Web Developer</h1>
<p> Building technology that builds community. Let’s create something meaningful together.</p>
<div className='hero__buttons-container'>
<Link to='/contact'>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Home/_Home.scss
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
.hero__text-container {
width: 60%;
@include true-center;
h2 {
h1 {
margin-bottom: 3rem;
}
p {
Expand Down
10 changes: 4 additions & 6 deletions src/components/Nav/Nav.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {useState, useEffect} from 'react';
import {useState} from 'react';
import {Link} from 'react-router-dom';
import logo from '../../assets/logo.png'
import BurgerNav from '../BurgerNav/BurgerNav';
Expand All @@ -17,11 +17,9 @@ const Nav = ({isOpen, setIsOpen}) => {
return (
<nav className='top-nav' >
<div className='top-nav__wrapper'>
<h1>
<Link to='/'>
<img src={logo} id='logo' alt='Rachel Soae Prather, Software Engineer' />
</Link>
</h1>
<Link to='/'>
<img src={logo} id='logo' alt='Rachel Soae Prather, Software Engineer' />
</Link>
<div className='top-nav__buttons'>
{isBurger === true ? <BurgerNav isOpen={isOpen} setIsOpen={setIsOpen} /> : <TopNav />}
</div>
Expand Down
6 changes: 1 addition & 5 deletions src/components/Nav/_Nav.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,8 @@
width: 100%;
}

h1 {
margin: 0 0 0 2rem;
}

#logo {
margin: 1rem 0 0;
margin: 1rem 0 0 2rem;
width: 29rem;
}

Expand Down
2 changes: 1 addition & 1 deletion src/components/Portfolio/Portfolio.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const Portfolio = () => {

return (
<div className='portfolio'>
<h2 className='page-header'>Portfolio</h2>
<h1 className='page-header'>Portfolio</h1>
<section className='portfolio__projects'>
{PROJECTS.map(project => <Project key={project.id} project={project} />)}
</section>
Expand Down
4 changes: 2 additions & 2 deletions src/components/Project/Project.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ const Project = ({project}) => {
className='card__back'
onMouseLeave={() => flipCard()}
>
<h3 className='card__title'>{name}</h3>
<h2 className='card__title'>{name}</h2>
<p className='card__tagline'>{tagline}</p>
<div className='tech'>
{techs.map(tech => {
return (
<div key={tech} className='tech__icon-container'>
<img className='tech__icon' src={ICONS[tech]} alt={tech} />
<img className='tech__icon' src={ICONS[tech]} alt="" />
<p className='tech__label'>{tech}</p>
</div>
)
Expand Down
19 changes: 7 additions & 12 deletions src/styles/output.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/styles/output.css.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e41da12

Please sign in to comment.