-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve pre-commit hooks, replace flake8 & pylint with ruff #2441
improve pre-commit hooks, replace flake8 & pylint with ruff #2441
Conversation
a000626
to
a286b67
Compare
a286b67
to
73c85de
Compare
3f93302
to
dfaa28f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2441 +/- ##
==========================================
- Coverage 90.18% 90.13% -0.05%
==========================================
Files 247 247
Lines 15677 15610 -67
==========================================
- Hits 14138 14070 -68
- Misses 1539 1540 +1
Continue to review full report in Codecov by Sentry.
|
64e90f6
to
9558248
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Summary
Replace
flake8
,isort
, andpylint
withruff
.What Changed
Added
check-toml
hooktoml-sort
hookmdformat
hookruff
ruff
's rulesChanged
pretty-format-json
to format more filesfiles
toexclude
foryamlfmt
hook so that it handles automatic formatting for more filesline-length
is now set to100
to allow longer linesblack
tolint
groupRemoved
black
hookblack
as a pre-commit hook, managing it's version and the versions of it's dependencies is difficult resulting in mismatches and errorsisort
hook asisort
is no longer in useflake8
hook asflake8
is no longer in useflake8
,isort
, andpylint
backports.cached_property
as it will never be installed with current python version requirementimportlib-metadata
as it will never be installed with current python version requirement