Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix intermittent test failure due time mismatch #2461

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

ITProKyle
Copy link
Collaborator

Why This Is Needed

resolves #1301

What Changed

Changed

  • changed test to only check for truthy value, not exact time of file creation

Fixed

@ITProKyle ITProKyle added maintenance General repo or CI/CD upkeep changelog:skip Don't include this pull request in the release change log labels Jul 23, 2024
@ITProKyle ITProKyle self-assigned this Jul 23, 2024
@github-actions github-actions bot added the python Update to Python code label Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (0c9a6b2) to head (8f519b1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2461   +/-   ##
=======================================
  Coverage   90.12%   90.13%           
=======================================
  Files         247      247           
  Lines       15610    15610           
=======================================
+ Hits        14069    14070    +1     
+ Misses       1541     1540    -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9a6b2...8f519b1. Read the comment docs.

@ITProKyle ITProKyle merged commit 224e614 into rackspace:master Jul 23, 2024
24 checks passed
@ITProKyle ITProKyle deleted the chore/time-issue branch July 23, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Don't include this pull request in the release change log maintenance General repo or CI/CD upkeep python Update to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TODO] fix time mismatch causing transient unit test failures
2 participants