Fix dyldcache deps carving logic ##bin #23044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dyldcache-specific logic which parses library-loading Mach-O load commands to carve dependencies in order to filter them was wrongly assuming the path of the loaded library is always at offset 24 instead of looking up the right offset from the command itself. While this was working 99.99% of the times, when it didn't it broke the deps carving logic and produced weird-looking "alien dep" errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dyldcache-specific logic which parses library-loading Mach-O load commands to carve dependencies in order to filter them was wrongly assuming the path of the loaded library is always at offset 24 instead of looking up the right offset from the command itself.
While this was working 99.99% of the times, when it didn't it broke the deps carving logic and produced weird-looking "alien dep" errors.