Fix advice for elisp--company-doc-buffer #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advice
radian--advice-company-elisp-use-helpfulreplaces(help-buffer)with(current-buffer)assuming that a helpful command will be called.However, this is only true for functions and variables. If
elisp--company-doc-bufferis called with a feature or a face, the current, unrelated, buffer is used when standardhelp-*commands are called, leading to the current buffer content being overwritten.The change in the PR gets around that issue but not overriding
help-buffer. The solution fixes the issue, but it still feels hacky and a better solution might be to patchelisp--company-doc-bufferinstead.