Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): reload jingles playlist in liquidsoap after expiring #197

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

spameier
Copy link
Member

@spameier spameier commented Nov 5, 2023

I solved our jingles not expiring problem in liquidsoap the dirty way. I do hope that liquidsoap +1.3.7 handles inotify better.

@spameier spameier requested a review from smlz November 5, 2023 20:07
@spameier
Copy link
Member Author

spameier commented Nov 7, 2023

We could also work around the issue with systemd service:

klangbecken-reload-jingles.service:

[Unit]
Description=Reload Jingles playlist after expire to workaround missing inotify support

[Service]
Type=simple
EnvironmentFile=/etc/klangbecken.conf
ExecStart=/bin/bash -c 'echo "jingles.reload" | nc -U ${KLANGBECKEN_PLAYER_SOCKET}'
User=liquidsoap
Group=liquidsoap

[Install]
WantedBy=multi-user.target

klangbecken-reload-jingles.timer:

[Unit]
Description=Run klangbecken-reload-jingles.service hourly at :30

[Timer]
OnCalendar=*-*-* *:05:30

[Install]
WantedBy=timers.target

@spameier
Copy link
Member Author

spameier commented Nov 7, 2023

Adding @hairmare because he might also have an opinion.

Copy link
Member

@smlz smlz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smlz smlz merged commit d6af3ad into radiorabe:master Nov 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants