Merge branch 'v0.30' into v0.31

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

.github/workflows/close-stale-prs.yml

@@ -0,0 +1,27 @@
+# This workflow warns and then closes PRs that have had no activity for 90 days.
+#
+# For more information, see:
+# https://github.com/actions/stale
+name: Close stale pull requests
+
+on:
+  schedule:
+  - cron: '0 18 * * *' # Run the workflow every day at 6PM UTC (10AM PST).
+
+jobs:
+  stale:
+
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+
+    steps:
+    - uses: actions/stale@v5
+      with:
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
+        stale-pr-message: 'This pull request has been automatically marked as stale because it has been inactive for 90 days. Remove stale label or comment or this PR will be closed in 7 days.'
+        stale-pr-label: 'stale'
+        days-before-pr-stale: 90 # 3 months
+        days-before-pr-close: 7
+        days-before-issue-stale: -1
+        days-before-issue-close: -1

.github/workflows/purge-aws-rds-snapshots.yaml

@@ -3,11 +3,22 @@ on:
   schedule:
     # Runs at 00:30 and 12:30
     - cron: "30 0,12 * * *"
+env:
+    GH_TOKEN: ${{ github.token }}
+    AWS_REGION: us-west-2
 jobs:
   purge_rds_snapshots:
     name: Purge AWS RDS DBInstance snapshots
     runs-on: [ubuntu-latest]
     steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+      - name: Login to AWS
+        run: |
+          aws configure set aws_access_key_id ${{ secrets.AWS_ACCESS_KEY_ID }}
+          aws configure set aws_secret_access_key ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+          aws configure set region ${{ env.AWS_REGION }}
+          aws configure set output json
       - name: Purge AWS RDS DBInstance snapshots
         run: |
           ./.github/scripts/purge-aws-rds-snapshots.sh

.github/workflows/test.yaml

@@ -4,9 +4,9 @@ on:
   workflow_dispatch:
     inputs:
       version:
-        description: 'Radius version number to use (e.g. 0.1.0, 0.1.0-rc1, edge). Defaults to edge.'
+        description: "Radius version number to use (e.g. 0.1.0, 0.1.0-rc1, edge). Defaults to edge."
         required: false
-        default: 'edge'
+        default: "edge"
         type: string
   push:
     branches:
@@ -76,7 +76,7 @@ jobs:
             enableDapr: false
           - name: eshop-azure
             os: ubuntu-latest
-            runOnPullRequest: false
+            runOnPullRequest: true
             app: eshop
             env: azure
             path: ./samples/eshop/eshop.bicep
@@ -85,7 +85,7 @@ jobs:
             enableDapr: false
           - name: eshop-aws
             os: ubuntu-latest
-            runOnPullRequest: false
+            runOnPullRequest: true
             app: eshop
             env: aws
             path: ./samples/eshop/eshop.bicep

CONTRIBUTING.md

@@ -0,0 +1,70 @@
+# Contributing Pull Requests
+
+## What to work on
+
+We welcome small pull request contributions from anyone (docs improvements, bug fixes, minor features.) as long as they follow a few guidelines:
+
+- For very minor changes like correcting a typo feel free to just send a pull request without any ceremony. Otherwise ... 
+- Please start by [choosing an existing issue](https://github.com/radius-project/samples/issues), or [opening an issue](https://github.com/radius-project/samples/issues/new/choose) to work on.
+- The maintainers will respond to your issue, please work with the maintainers to ensure that what you're doing is in scope for the project before writing any code.
+- If you have any doubt whether a contribution would be valuable, feel free to ask.
+
+We the maintainers have discretion over what features and pull requests we accept. Please understand that we are responsible for the long-term support and maintenance of Radius, and so we sometimes need to make hard decisions to limit the scope. For another perspective on this, we really like this [article](https://www.igvita.com/2011/12/19/dont-push-your-pull-requests/).
+
+## Sending a pull request
+
+Please submit pull requests using a forked repo and open pull requests against:
+
+- The default, versioned branch (`v0.30` for example) if you are adding/fixing a sample and it is compatible with the latest release of Radius.
+- The `edge` branch if you are contributing a sample that requires a feature that will be available in the next release of Radius.
+
+When opening a pull request, the form will be pre-populated with our template. Please fill out the template to provide structure to your PR message. If you've already written a good commit message (see below) it will be easy to use with our template.
+
+A pull request will need to pass the following checkpoints to be accepted:
+
+- Initial review: a maintainer will review your summary and make sure an appropriate issue is linked
+- Testing: automated tests will run against your changes
+- Code review: you will get feedback from a maintainer or other contributors in the form of comments
+
+## Writing a good commit message
+
+We value good commit messages that are descriptive and meaningful at a glance. A good format to follow is like the following:
+
+```txt
+<short description>
+
+Fixes: #<issue>
+
+<a longer description that includes>
+
+- a summary of the changes being made
+- the rationale for the change
+- (optional) anything tricky or difficult as a heads up for reviewers
+- (optional) additional follow up work that should be done (with links)
+```
+
+We **squash** pull-requests as part of the merge process, which means that intermediate commits will have their messages appended. We prefer to have a single commit in the git history for each PR.
+
+## Code review
+
+The maintainers or other contributors will add comments to your pull request giving feedback, asking questions, and making suggestions. Please respond to these comments to either continue the discussion or explain whether or not you plan to address the feedback. Ultimately, accepting a pull request is at the maintainer's discretion.
+
+### Being proactive 
+
+It can be helpful for you to comment on your own PR to point out relevant locations, decisions, opportunities for feedback, and tricky parts. This will help reviewers focus their attention as well as save them time.
+
+### Resolving Feedback
+
+You can "resolve" comments on your pull request when you've addressed the feedback: either through discussion or through making a code change. As the contributor of the pull-request feel free to mark comments as resolved when you feel like you've done a reasonable job addressing the feedback.
+
+If you are the code reviewer, it's your responsibility to follow up (politely) if you feel your feedback has not been addressed adequately.
+
+### Participating in code review
+
+We welcome **any contributor or community member** to engage with **any pull request** on our repository. Feel free to make suggestions for improvements and ask questions that are relevant. If you're asking questions for your learning, please make it clear that your questions are "non-blocking" for the pull request.
+
+See the [code reviewing documentation](https://github.com/radius-project/radius/blob/main/docs/contributing/contributing-code/contributing-code-reviewing/README.md) for guidance on code reviewing.
+
+## Inactive Pull Requests
+
+Pull requests that have been inactive for 90 days will be marked with a stale label. They will automatically be closed after a subsequent 7 days of inactivity. This timeframe may be adjusted in the future based on project needs.

playwright/package.json

@@ -8,12 +8,13 @@
   "author": "",
   "license": "ISC",
   "devDependencies": {
-    "@playwright/test": "^1.35.0",
-    "@types/node": "^20.6.0",
-    "@types/uuid": "^9.0.3",
-    "typescript": "^5.2.2"
+    "@playwright/test": "^1.41.2",
+    "@types/node": "^20.11.19",
+    "@types/uuid": "^9.0.8",
+    "typescript": "^5.3.3"
   },
   "dependencies": {
-    "uuid": "^9.0.0"
+    "axios": "^1.6.7",
+    "uuid": "^9.0.1"
   }
 }