Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force delete Radius application, EKS Cluster, and AWS resources on failed workflow run #843

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Force delete Radius application, EKS Cluster, and AWS resources on failed workflow run #843

merged 1 commit into from
Nov 27, 2023

Conversation

willdavsmith
Copy link
Contributor

@willdavsmith willdavsmith commented Nov 20, 2023 •
edited
Loading

  • update delete-aws-resources for new recipe related changes
  • force delete EKS cluster
  • always delete radius app

Fixes: #827

@willdavsmith willdavsmith requested a review from a team as a code owner November 20, 2023 18:11
@ytimocin
Copy link
Collaborator

Is this going to solve #827 @willdavsmith? cc/ @vishwahiremat @nicolejms

@willdavsmith
Copy link
Contributor Author

Is this going to solve #827 @willdavsmith? cc/ @vishwahiremat @nicolejms

I hope that it will. It's not a direct fix but it should help two things.

  1. The deletion of the EKS cluster kept failing because there were subnets in use. I think this was because of RDS and MemoryDB instances left hanging. Forcing the application to delete should help alleviate this.
  2. We will now force delete the EKS cluster. Hopefully this should cause the EKS cluster to delete everything else even if it can't delete the subnets.

@willdavsmith
Fix test workflow for aws resources
102130c 
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
@willdavsmith willdavsmith force-pushed the willdavsmith/test-workflow-updates branch from cf62c0a to 102130c Compare November 21, 2023 00:11
@willdavsmith willdavsmith mentioned this pull request Nov 27, 2023
Closed
ytimocin
ytimocin approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@ytimocin ytimocin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test this out! LGTM.

@willdavsmith willdavsmith merged commit 4855d47 into radius-project:edge Nov 27, 2023
19 of 20 checks passed
This was referenced Nov 28, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 28, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
willdavsmith added a commit that referenced this pull request Nov 28, 2023
@willdavsmith
Force delete Radius application, EKS Cluster, and AWS resources on fa…
06b067e 
…iled workflow run (#843)

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
(cherry picked from commit 4855d47)
@willdavsmith willdavsmith mentioned this pull request Nov 28, 2023
Merged
AaronCrawfis pushed a commit that referenced this pull request Nov 28, 2023
@willdavsmith
Fix failing CI in 0.27 branch (#881)
a420f9e 
* Fix Dapr sample in CI (#817)

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* make sure it's not flaky

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* remove debug

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

---------

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
(cherry picked from commit 5f6bd44)

* Force delete Radius application, EKS Cluster, and AWS resources on failed workflow run (#843)

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
(cherry picked from commit 4855d47)
@AaronCrawfis AaronCrawfis mentioned this pull request Nov 28, 2023
Closed
@willdavsmith willdavsmith mentioned this pull request Nov 28, 2023
Closed
This was referenced Nov 28, 2023
Closed
Closed
willtsai pushed a commit to willtsai/samples-radius that referenced this pull request Dec 13, 2023
@willdavsmith @willtsai
Force delete Radius application, EKS Cluster, and AWS resources on fa…
1e843ca 
…iled workflow run (radius-project#843)

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
jonvsm pushed a commit that referenced this pull request Dec 13, 2023
@willtsai @willdavsmith
@AaronCrawfis @dependabot @ASHIQUEMD
Upmerge v0.27 to v0.28 (#903)
175425b 
* Add edge rad CLI pull to samples tests (#737)

* Add install-radius script

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* chmod

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* PR

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* PR

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* PR

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* PR

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* PR

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* PR

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

---------

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* dapr tutorial port and routes fixes

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Revert "Update container build to only push on merges (#726)"

This reverts commit 54b3d4e.

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Revert "Revert "Update container build to only push on merges (#726)""

This reverts commit 7cfd4ad.

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Revert "dapr tutorial port and routes fixes"

This reverts commit 7f6f525.

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* dapr tutorial port and routes fixes (#748)

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Update condition

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Update rad-bicep pull

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Update eShop to use Recipes (#590)

* Replace eShop with eShop on recipes

* PR

* Fix

* Test

* PR

* oops

* Updates

* PR

* PR

* PR

* PR comments

* PR comments

* fixing

* again

* fix

* rewind

* PR

* PR

* Simplify env registration

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Make registry a parameter

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Update test

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Update namespaces

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Fix tag

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Update env names

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Fix namespaces

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Fix recipe

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

---------

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Fix Dapr sample in CI (#817)

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* make sure it's not flaky

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* remove debug

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

---------

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Force delete Radius application, EKS Cluster, and AWS resources on failed workflow run (#843)

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Remove customer label

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Add issue labels (#858)

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Bump @adobe/css-tools from 4.3.1 to 4.3.2 in /samples/demo/client (#886)

Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Fix Dapr microservices sample (#654) (#890)

* Adding application name for dapr app

* Adding application name for dapr app

* Update samples/dapr/.rad/rad.yaml

---------

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Co-authored-by: MD Ashique <noorani.ashique5@gmail.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Will Smith <willdavsmith@gmail.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: MD Ashique <noorani.ashique5@gmail.com>
willdavsmith added a commit that referenced this pull request Apr 22, 2024
@willdavsmith @AaronCrawfis
@dependabot @jkotalik @willtsai @ASHIQUEMD @lakshmimsft @kachawla @ytimocin @Reshrahim
Upmerge release branches into edge (#1212)
2717f4e 
* Fix resource type

* Fix Dapr mode

* Bump express from 4.17.1 to 4.17.3 in /quickstarts/dapr/nodeapp (#108)

Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.17.3.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.17.1...4.17.3)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump loader-utils from 2.0.3 to 2.0.4 in /demo/client (#111)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.3 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.3...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump minimatch from 3.0.4 to 3.1.2 in /tutorial (#114)

Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases)
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v3.0.4...v3.1.2)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump decode-uri-component from 0.2.0 to 0.2.2 in /tutorial (#113)

Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump minimatch in /reference-apps/container-app-store/node-service (#112)

Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases)
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v3.0.4...v3.1.2)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump qs and express in /reference-apps/container-app-store/node-service (#110)

Bumps [qs](https://github.com/ljharb/qs) to 6.11.0 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `qs` from 6.5.2 to 6.11.0
- [Release notes](https://github.com/ljharb/qs/releases)
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](ljharb/qs@v6.5.2...v6.11.0)

Updates `express` from 4.16.4 to 4.18.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.16.4...4.18.2)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump express from 4.17.1 to 4.17.3 in /tutorial (#109)

Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.17.3.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.17.1...4.17.3)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Making tutorial match docs version (#116)

* Continue on error for container deletion

* Update issues.yaml

* Change ADO_wit

* Update version number

* Remove container app store

* Add eshop instructions

* Revert instructions

* Change Bicep installation step

* Update issues.yaml

* Update issues.yaml

* Update issues.yaml

* Update test.yaml

* Add check for node creation (#240)

* Add check for node creation

* Correct error message

* Add contribution guide

* Add Issue templates

* Fix link

* Fix casing

* change mentions of <Project Radius> to just <Radius> (#263)

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* edge to v0.22 upmerge to pick up  changes (#388)

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* add background info for dapr quickstart (#381)

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Switch to sql edge (#398)

* Update Dapr UI port (#416)

* Change port to 8080

* Update container port

* Update configuration

* Add error message

* Update demo.app.spec.ts (#546)

* Add samples release automation (#499) (#554)

* Bump word-wrap from 1.2.3 to 1.2.5 in /demo/client (#431)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Bump golang.org/x/net in /reference-apps/container-app-store/go-service (#593)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20210929193557-e81a3d93ecf6 to 0.17.0.
- [Commits](https://github.com/golang/net/commits/v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add issue labels (#858)

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Remove customer label

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Fix failing CI in 0.27 branch  (#881)

* Fix Dapr sample in CI (#817)

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* make sure it's not flaky

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* remove debug

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

---------

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
(cherry picked from commit 5f6bd44)

* Force delete Radius application, EKS Cluster, and AWS resources on failed workflow run (#843)

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
(cherry picked from commit 4855d47)

* Bump @adobe/css-tools from 4.3.1 to 4.3.2 in /samples/demo/client (#886)

Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix Dapr microservices sample (#654)

* Adding application name for dapr app

* Adding application name for dapr app

* Update samples/dapr/.rad/rad.yaml

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Fix Dapr microservices sample (#654) (#890)

* Adding application name for dapr app

* Adding application name for dapr app

* Update samples/dapr/.rad/rad.yaml



---------

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Co-authored-by: MD Ashique <noorani.ashique5@gmail.com>

* Upmerge v0.27 to v0.28 (#903)

* Add edge rad CLI pull to samples tests (#737)

* Add install-radius script

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* chmod

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* test

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* PR

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* PR

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* PR

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* PR

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* PR

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* PR

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

---------

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* dapr tutorial port and routes fixes

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Revert "Update container build to only push on merges (#726)"

This reverts commit 54b3d4e.

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Revert "Revert "Update container build to only push on merges (#726)""

This reverts commit 7cfd4ad.

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Revert "dapr tutorial port and routes fixes"

This reverts commit 7f6f525.

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* dapr tutorial port and routes fixes (#748)

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Update condition

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Update rad-bicep pull

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Update eShop to use Recipes (#590)

* Replace eShop with eShop on recipes

* PR

* Fix

* Test

* PR

* oops

* Updates

* PR

* PR

* PR

* PR comments

* PR comments

* fixing

* again

* fix

* rewind

* PR

* PR

* Simplify env registration

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Make registry a parameter

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Update test

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Update namespaces

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Fix tag

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Update env names

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Fix namespaces

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Fix recipe

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

---------

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Fix Dapr sample in CI (#817)

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Adding debug for pod list

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* make sure it's not flaky

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* remove debug

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

---------

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Force delete Radius application, EKS Cluster, and AWS resources on failed workflow run (#843)

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Remove customer label

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Add issue labels (#858)

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Bump @adobe/css-tools from 4.3.1 to 4.3.2 in /samples/demo/client (#886)

Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Fix Dapr microservices sample (#654) (#890)

* Adding application name for dapr app

* Adding application name for dapr app

* Update samples/dapr/.rad/rad.yaml

---------

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Co-authored-by: MD Ashique <noorani.ashique5@gmail.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Will Smith <willdavsmith@gmail.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: MD Ashique <noorani.ashique5@gmail.com>

* Update changes in test.yaml workflow into v0.28 (#904)

* Add test-failure label to issues created for samples failures (#899)

Signed-off-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
Co-authored-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>

* updating condition to specify scheduled run

---------

Signed-off-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com>
Co-authored-by: Karishma Chawla <kachawla@microsoft.com>
Co-authored-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>

* Fixing AWS RDS Purge workflow (#970)

* Add aws login (#974)

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

* Add GH action to close stale PRs (#977)

* Add GH action to close stale PRs

Signed-off-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>

* Update CONTRIBUTING.md

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>

* Update radius repo link

Signed-off-by: Karishma Chawla <kachawla@microsoft.com>

---------

Signed-off-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
Co-authored-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Adding a secton that waits until the app is ready (#980)

Signed-off-by: ytimocin <ytimocin@microsoft.com>

* Update images for guestbook sample app (#986)

* update images for guestbook sample app

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* update images for guestbook sample app

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* move images to /samples path

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /samples/demo/client (#1023)

Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

---
updated-dependencies:
- dependency-name: webpack-dev-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump follow-redirects from 1.15.4 to 1.15.6 in /samples/demo/client (#1014)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ip from 2.0.0 to 2.0.1 in /samples/demo (#984)

Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Bump follow-redirects from 1.15.5 to 1.15.6 in /playwright (#1015)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Bump express from 4.18.2 to 4.19.2 in /samples/demo/client (#1027)

Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Bump express from 4.18.2 to 4.19.2 in /samples/demo (#1028)

Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Bump express from 4.18.2 to 4.19.2 in /samples/dapr/nodeapp (#1026)

Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Make env configurable (#1046)

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Adding test AKS workflow to v0.32 (#1052)

* Run functional tests every 2 hours and add another workflow that runs… (#1020)

* Run functional tests every 2 hours and add another workflow that runs the tests on AKS instead of k3d

Signed-off-by: ytimocin <ytimocin@microsoft.com>

* Triggering workflow

Signed-off-by: ytimocin <ytimocin@microsoft.com>

---------

Signed-off-by: ytimocin <ytimocin@microsoft.com>

* Removing the run of the AKS workflow on PRs (#1051)

Signed-off-by: ytimocin <ytimocin@microsoft.com>

* Update the timeout (30s) for Playwright

Signed-off-by: ytimocin <ytimocin@microsoft.com>

---------

Signed-off-by: ytimocin <ytimocin@microsoft.com>

* Removing code

* Removing code

* Removing code

* Use retry and update eshop playwright tests to wait for the catalog to appear (#1213)

Signed-off-by: ytimocin <ytimocin@microsoft.com>

* Fixing eshop page

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Signed-off-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com>
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
Signed-off-by: ytimocin <ytimocin@microsoft.com>
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Kotalik <jukotali@microsoft.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>
Co-authored-by: MD Ashique <noorani.ashique5@gmail.com>
Co-authored-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com>
Co-authored-by: Karishma Chawla <kachawla@microsoft.com>
Co-authored-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
Co-authored-by: Yetkin Timocin <ytimocin@microsoft.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytimocin ytimocin ytimocin approved these changes

@willtsai willtsai willtsai approved these changes

@AaronCrawfis AaronCrawfis AaronCrawfis approved these changes

@Reshrahim Reshrahim Awaiting requested review from Reshrahim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@willdavsmith @ytimocin @willtsai @AaronCrawfis