Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module-info.java #42

Open
KleaTech opened this issue Jan 18, 2020 · 5 comments
Open

Add module-info.java #42

KleaTech opened this issue Jan 18, 2020 · 5 comments

Comments

@KleaTech
Copy link

So that it will be a dedicated module instead of an automatic one.

@aino-gautam
Copy link

@KleaTech what module system are you referring to ? Jar packaging or something else like OSGI ?

@KleaTech
Copy link
Author

KleaTech commented Feb 17, 2020

I'm of course referring to the Java module system

@KleaTech
Copy link
Author

However I tried to do it myself and it is not possible as long as you use Xerces. Neko HTML also had to be replaced, but it was relatively easy. I don't remember what I used instead.

@radkovo
Copy link
Owner

radkovo commented Mar 25, 2020

Pdf2Dom still targets to Java 8 so the modularization of the library could cause problems. However, I added the Automatic-Module-Name: net.sf.cssbox.pdf2dom declaration to the manifest so that the automatic module name should be stable now. Does it solve your problem?

I have also moved the CSSBox bindings to a separate projects so now the dependencies so now it should not depend on xerces and NekoHTML anymore. (see the recent commits in master)

@KleaTech
Copy link
Author

The stable module name is nice to have. It's best to add it to every project that targets java 8 or earlier. However for what I tried to do, it's not enough. I tried to pack my own JRE with jlink, but to use it all dependencies in the dependency hierarchy must be a Java module, no automatic module can be used anywhere. As I said earlier this can be done except for Xerces.
Removing to CSSBox dependency may solve this problem, I will check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants