catch unbound localerror #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitchyr
requested changes
Jan 13, 2019
There was a problem hiding this comment.
This seems to have a bunch of other changes other than the unbound local error. Can you separate these things into separate PRs? The default of not using a GPU is reasonable, but I'm not sure (e.g.) why we should move the scripts into their own module or comment out the code that checks if launching EC2 is okay.
|
Updated to only include the gpu and unboundlocalerror |
|
Oh, there's also the movement of the scripts folder. I made an issue about it. If thats intended and something else is going on, I can change that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.