Scoped attribute keys with a generated prefix #125
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124
It's common for models to "belong" to a parent model, such as a user or identity. Previously scoping Redis keys to a parent would require custom key generation. With this change it's possible to scope the attribute keys to the parent model, so that the keys can be easily identified and deleted in case of a user deletion. This scoping takes the form of a prefix, e.g.:
model_name:1
Here's some real-ish examples from HEY, where it's common for classes to relate to a parent class.
Before
Notice the inconsistent key construction,
:
vs/
,identities
vsidentity
namespace, and varying namespacing for the class - training but no widget.Time for some conventions:
After
scope
is a model attribute-only option, and it takes a string, proc, or symbol. A string or a proc simply return a prefix, but the symbol is sent and the return value assumed to be a model with an appropriate#id
.cc @jeremy @jorgemanrubia