Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rails UJS as a dependency #3644

Open
caiofct opened this issue Sep 4, 2023 · 0 comments
Open

Remove Rails UJS as a dependency #3644

caiofct opened this issue Sep 4, 2023 · 0 comments

Comments

@caiofct
Copy link

caiofct commented Sep 4, 2023

Is your feature request related to a problem? Please describe.

Turbo was introduced since version 3.0 of this gem and now has support for every feature Rails UJS has. We wouldn't need to have Rails UJS as a dependency anymore and, even thought Turbo and UJS can coexist in a Rails project, having one less dependency would be ideal IMHO.

Describe proposed solution(s)
Migrate the Rails UJS usage like data-method, data-confirm etc... to Turbo equivalents. There's a handy guide on how to perform the migration: https://dev.to/thomasvanholder/how-to-migrate-rails-ujs-to-hotwire-turbo-hdh

Additional context
I still saw some method: usages through the codebase here but not sure if there's any other things that might be blocking this migration or if it has been considered before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant