Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prettytable stubs #220

Closed
wants to merge 1 commit into from

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Oct 12, 2024

prettytable includes typing information and a py.typed file since 3.5.0. The stubs are no longer necessary.

https://github.com/jazzband/prettytable/releases/tag/3.5.0

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.13%. Comparing base (3fbf20f) to head (0f926b8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files           1        1           
  Lines         462      462           
=======================================
  Hits          458      458           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdce8p cdce8p marked this pull request as draft October 12, 2024 21:05
@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 12, 2024

The upstream stubs are quite incomplete (as of prettytable 3.11.0). Let's leave it as is for the time being.

@cdce8p cdce8p closed this Oct 12, 2024
@cdce8p cdce8p deleted the remove-prettytable-stubs branch October 12, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant