Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #467
Description
These changes allow DataGateway API to be installed using
pip install
- the fix is simply just to explicitly state which version of Flask should be used instead of the installation process trying to figure that out. Normally that wouldn't be an issue, but we're having to use quite an old version of Flask that still supports Python 3.6. There's also some updates topoetry.lock
as a result - a lot of that is just upgrading other dependencies as the file hasn't changed in a little while.I've added a job to the CI to keep track of this - you can see in this run (before Flask was pinned), that new job fails on Python 3.8+, giving the same error that was originally found but the CI now passes.
When the PR is merged, it will create v9.0.2 so you'll be able to use this new version with SciGateway Ansible.
Testing Instructions
Take a look at the CI and check you're happy with it and try to pip install the API on your own machine.
icatdb Generator Script Consistency Test
CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:
,feat:
orBREAKING CHANGE:
so a release is automatically made via GitHub Actions upon merge?Agile Board Tracking
Connect to #467