Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.1.2 #1584

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Release v1.1.2 #1584

merged 3 commits into from
Sep 28, 2023

Conversation

louise-davies
Copy link
Member

@louise-davies louise-davies commented Sep 28, 2023

Description

Hotfix release to fix #1582 on DLS production.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f0e75b6) 97.49% compared to head (cbfd5e0) 97.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
+ Coverage   97.49%   97.52%   +0.02%     
==========================================
  Files         134      134              
  Lines        6827     6901      +74     
  Branches     2094     2069      -25     
==========================================
+ Hits         6656     6730      +74     
  Misses        155      155              
  Partials       16       16              
Flag Coverage Δ
common 98.17% <100.00%> (+<0.01%) ⬆️
dataview 98.04% <100.00%> (+0.06%) ⬆️
download 94.96% <ø> (ø)
search 97.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/datagateway-common/src/api/datafiles.tsx 97.72% <100.00%> (+0.05%) ⬆️
packages/datagateway-common/src/api/datasets.tsx 100.00% <100.00%> (ø)
...ages/datagateway-common/src/api/facilityCycles.tsx 100.00% <100.00%> (ø)
...ackages/datagateway-common/src/api/instruments.tsx 100.00% <100.00%> (ø)
...ages/datagateway-common/src/api/investigations.tsx 100.00% <100.00%> (ø)
packages/datagateway-common/src/api/studies.tsx 100.00% <100.00%> (ø)
...c/views/card/dls/dlsDatasetsCardView.component.tsx 100.00% <100.00%> (ø)
.../views/card/dls/dlsProposalsCardView.component.tsx 100.00% <100.00%> (ø)
...src/views/card/dls/dlsVisitsCardView.component.tsx 100.00% <100.00%> (ø)
...views/card/isis/isisDatasetsCardView.component.tsx 98.07% <100.00%> (+0.11%) ⬆️
... and 16 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louise-davies louise-davies marked this pull request as ready for review September 28, 2023 12:24
Copy link
Contributor

@kaperoo kaperoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😊

@louise-davies louise-davies merged commit 4f29f5e into main Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants