Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.0.0 #1661

Merged
merged 1,698 commits into from
Jul 24, 2024
Merged

Release v2.0.0 #1661

merged 1,698 commits into from
Jul 24, 2024

Conversation

louise-davies
Copy link
Member

Description

Release v2.0.0

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

louise-davies and others added 30 commits September 29, 2023 11:32
this fixes the ability to select/deselect items
…o display facet counts

- currently only added the instrument fix to DatafileSearchTable
Won't run on CI yet
Also, fixed a few minor bugs I found
Would need to re-source .bashrc to pick it up from PATH - this is easier
The tooltips appearing slow the tests down so that they risk timing out
tests keep timing out so this might help?
this prevents the plugin from doing any background loading whilst SG maintenance mode is active
Made it more efficient by bundling it all together in the current tab change
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.13 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…babel/traverse-7.23.2

Bump @babel/traverse from 7.20.13 to 7.23.2
VKTB and others added 24 commits March 22, 2024 10:43
…follow-redirects-1.15.6

Bump follow-redirects from 1.15.5 to 1.15.6
…webpack-dev-middleware-5.3.4

Bump webpack-dev-middleware from 5.3.3 to 5.3.4
Bumps [express](https://github.com/expressjs/express) from 4.18.1 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.1...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
…express-4.19.2

Bump express from 4.18.1 to 4.19.2
Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.13 to 6.2.1.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.1.13...v6.2.1)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ws](https://github.com/websockets/ws) from 7.5.9 to 7.5.10.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.5.9...7.5.10)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ejs](https://github.com/mde/ejs) from 3.1.8 to 3.1.10.
- [Release notes](https://github.com/mde/ejs/releases)
- [Commits](mde/ejs@v3.1.8...v3.1.10)

---
updated-dependencies:
- dependency-name: ejs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…braces-3.0.3

Bump braces from 3.0.2 to 3.0.3
…ejs-3.1.10

Bump ejs from 3.1.8 to 3.1.10
Plus auto-generate release notes
- don't know what changed to cause this, likely backend changes
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 84.94624% with 70 lines in your changes missing coverage. Please review.

Project coverage is 95.35%. Comparing base (cebcd8b) to head (6cb8de5).
Report is 7 commits behind head on main.

Files Patch % Lines
...datagateway-common/src/card/cardView.component.tsx 47.14% 37 Missing ⚠️
...tagateway-common/src/card/entityCard.component.tsx 40.00% 9 Missing ⚠️
packages/datagateway-common/src/testData.ts 0.00% 6 Missing ⚠️
...s/datagateway-common/src/table/table.component.tsx 83.87% 3 Missing and 2 partials ⚠️
packages/datagateway-common/src/urlBuilders.ts 88.88% 5 Missing ⚠️
.../detailsPanels/dls/visitDetailsPanel.component.tsx 83.33% 3 Missing and 1 partial ⚠️
packages/datagateway-common/src/api/index.tsx 93.87% 3 Missing ⚠️
...src/table/headerRenderers/dataHeader.component.tsx 97.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1661      +/-   ##
==========================================
- Coverage   96.53%   95.35%   -1.18%     
==========================================
  Files         159      182      +23     
  Lines        7038     7843     +805     
  Branches     2240     2507     +267     
==========================================
+ Hits         6794     7479     +685     
- Misses        223      329     +106     
- Partials       21       35      +14     
Flag Coverage Δ
common 94.17% <84.94%> (-1.56%) ⬇️
dataview 97.32% <ø> (+0.44%) ⬆️
download 95.99% <ø> (-1.02%) ⬇️
search 93.57% <ø> (-3.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me locally, deployed version LGTM.

Copy link
Contributor

@joshuadkitenge joshuadkitenge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well locally and works well on the deployed version

@louise-davies louise-davies merged commit f1d5830 into main Jul 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants