increase TextFilter debounce timer to 500ms #1662 #1666
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1666 +/- ##
========================================
Coverage 95.35% 95.35%
========================================
Files 182 182
Lines 7843 7844 +1
Branches 2490 2497 +7
========================================
+ Hits 7479 7480 +1
Misses 329 329
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -12,7 +12,7 @@ import userEvent from '@testing-library/user-event'; | |||
|
|
|||
| jest.mock('../../api'); | |||
| jest.useFakeTimers('modern'); | |||
| const DEBOUNCE_DELAY = 250; | |||
| const DEBOUNCE_DELAY = 500; | |||
There was a problem hiding this comment.
It might be worth moving this variable to the actual component, and export it to use it in both the tests and when passing the actual debounce - it means in the future if we edit the debounce we only have to change it in one place :) Just an opportunity to refactor the code to be a little more future-proof
Otherwise good work!
There was a problem hiding this comment.
Thanks Louise! Okay I understand, I've made and pushed the change.
Description
increase TextFilter debounce timer to 500ms
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #1662