-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow query retry setting to be configurable #1677
Conversation
…ry query retry behaviour
… or module mock implementation being outdated
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1677 +/- ##
===========================================
+ Coverage 95.35% 96.01% +0.65%
===========================================
Files 182 124 -58
Lines 7844 5122 -2722
Branches 2482 1603 -879
===========================================
- Hits 7480 4918 -2562
+ Misses 329 178 -151
+ Partials 35 26 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally worked well for me, just one query.
- Remove TODO - Refactor duplicate code into dg-common
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adds a setting to all plugins that allows the sysadmin to set the react query query retry behaviour to whatever they want. I just let them set any number, including 0 to effectively disable retries even though setting false would have the same effect as keeping it as a number made typing easier.
This was requested by DLS as they have problems with queries timing out and they generally don't want to retry them, at the very least not 3 times like the current default. I opted away from limiting it to just problematic queries or from trying to figure out error messages indicating a query timeout and just made it a global config option.
Testing instructions
Add a set up instructions describing how the reviewer should test the code