Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datagateway-download e2e tests broken by minting api update #1681

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

louise-davies
Copy link
Member

Description

The minting api wasn't pinned in the CI (due to it only having tagged containers later in development than the original CI script) and so the release of v0.3.0 a couple of weeks ago broke the CI. I've now pinned the api to v0.3.0 and updated the broken test (just the format of an error message had changed)

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.39%. Comparing base (1cdb0e3) to head (49a9aa4).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1681   +/-   ##
========================================
  Coverage    95.39%   95.39%           
========================================
  Files          183      183           
  Lines         7932     7932           
  Branches      2516     2516           
========================================
  Hits          7567     7567           
  Misses         330      330           
  Partials        35       35           
Flag Coverage Δ
common 94.27% <ø> (ø)
dataview 97.32% <ø> (ø)
download 96.03% <ø> (ø)
search 93.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@louise-davies louise-davies merged commit ab85223 into develop Nov 20, 2024
10 checks passed
@louise-davies louise-davies deleted the fix-broken-doi-e2e-test branch November 20, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants