Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from object-storage-api repo setup #383

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

joelvdavies
Copy link
Collaborator

@joelvdavies joelvdavies commented Sep 20, 2024

Description

Changes made while working on ral-facilities/object-storage-api#10.

Warning

Everyone with this cloned for local development should run the following when this is merged/for testing this branch

sudo rm -rf mongodb/data
git restore mongodb/data/.keep
python3.12 scripts/dev_cli.py db-init

and if you wish to use the mock data

python3.12 scripts/dev_cli.py db-import

This will ensure the replica set config is updated to have the correct host.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

@joelvdavies joelvdavies added the enhancement New feature or request label Sep 20, 2024
@joelvdavies joelvdavies self-assigned this Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (e75104d) to head (535bca4).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #383   +/-   ##
========================================
  Coverage    97.86%   97.86%           
========================================
  Files           41       41           
  Lines         1502     1502           
========================================
  Hits          1470     1470           
  Misses          32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelvdavies joelvdavies marked this pull request as ready for review September 20, 2024 12:42
@joelvdavies joelvdavies requested a review from VKTB September 20, 2024 12:42
@joelvdavies joelvdavies merged commit a4deafc into develop Sep 23, 2024
8 checks passed
@joelvdavies joelvdavies deleted the minor-changes-from-object-storage-api branch September 23, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants