Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of mock generated data #392 #397

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

joelvdavies
Copy link
Collaborator

@joelvdavies joelvdavies commented Oct 14, 2024

Description

Adjusts the generate_mock_data script to generate less data overall by fixing a bug with system generation producing subsystems down though MAX_LEVELS_DEEP + 1 and reducing some of the constants . See the screenshots below.
Old:
image

New:
image

This makes it considerably faster and should make it quicker to populate mock data for the object_storage_api. This PR also makes some modifications in line with ral-facilities/object-storage-api#43.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Closes #392

@joelvdavies joelvdavies added the enhancement New feature or request label Oct 14, 2024
@joelvdavies joelvdavies self-assigned this Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (5931ed9) to head (11f588f).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #397   +/-   ##
========================================
  Coverage    97.87%   97.87%           
========================================
  Files           41       41           
  Lines         1504     1504           
========================================
  Hits          1472     1472           
  Misses          32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelvdavies joelvdavies force-pushed the reduce-mock-data-size-#392 branch from 4032bf3 to ae0f572 Compare October 15, 2024 09:03
VKTB
VKTB previously approved these changes Oct 18, 2024
@joelvdavies joelvdavies merged commit 86211c4 into develop Oct 21, 2024
7 of 8 checks passed
@joelvdavies joelvdavies deleted the reduce-mock-data-size-#392 branch October 21, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce number of entities generated by mock data script
2 participants