Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to production Docker image #78

Merged
merged 5 commits into from
May 30, 2024
Merged

Changes to production Docker image #78

merged 5 commits into from
May 30, 2024

Conversation

VKTB
Copy link
Collaborator

@VKTB VKTB commented May 30, 2024

Description

This PR fixes the issue reported in #76 so any custom images created using the prod Docker image from Harbor as the base image while being in a different working directory would not result in any issues now. It also addresses #77 so the default logging in the prod Docker image will be to the console.

Testing instructions

Add a set of instructions describing how the reviewer should test the code

# Use the LDAP JWT Authentication image on Harbor as the base image
FROM harbor.stfc.ac.uk/ldap-jwt-authentication/auth-api:pr-78

WORKDIR /ldap-jwt-auth-run

USER root

RUN set -eux; \
    \
    mkdir logs; \
    \
    # Change ownership of logs/ - app will need to write log files to it \
    chown -R ldap-jwt-auth:ldap-jwt-auth logs/;

WORKDIR /ldap-jwt-auth-run/ldap_jwt_auth

# Copy the custom logging.ini file
COPY --chown=ldap-jwt-auth:ldap-jwt-auth logging.ini ./logging.ini

USER ldap-jwt-auth

Agile board tracking

closes #76
closes #77

@VKTB VKTB marked this pull request as ready for review May 30, 2024 11:07
@VKTB VKTB requested a review from joelvdavies May 30, 2024 11:08
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VKTB VKTB merged commit d16f824 into main May 30, 2024
5 checks passed
@VKTB VKTB deleted the prod-docker-image-changes branch May 30, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants