Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup MongoDB and S3 clients #4 #10

Merged
merged 10 commits into from
Sep 23, 2024

Conversation

joelvdavies
Copy link
Collaborator

@joelvdavies joelvdavies commented Sep 19, 2024

Description

See #4. Adds config for connecting to a MongoDB instance and the DatabaseDep from inventory-management-system-api. Also adds config for connecting to an S3 instance and a MinIO instance to the docker-compose.yml for development.

Notes

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Closes #4

@joelvdavies joelvdavies added the enhancement New feature or request label Sep 19, 2024
@joelvdavies joelvdavies self-assigned this Sep 19, 2024
@joelvdavies joelvdavies force-pushed the setup-monogo-db-and-s3-clients-#4 branch 2 times, most recently from fbdbbe9 to 490b4ad Compare September 20, 2024 11:25
@joelvdavies joelvdavies force-pushed the setup-monogo-db-and-s3-clients-#4 branch from 490b4ad to 8e367ed Compare September 20, 2024 11:27
@joelvdavies joelvdavies requested a review from VKTB September 20, 2024 11:29
@joelvdavies joelvdavies marked this pull request as ready for review September 20, 2024 11:29
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@VKTB
Copy link
Collaborator

VKTB commented Sep 23, 2024

pip install -r requirements.txt is failing on Windows btw

Collecting uvloop==0.20.0 (from -r requirements.txt (line 48))
  Downloading uvloop-0.20.0.tar.gz (2.3 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.3/2.3 MB 4.3 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      Traceback (most recent call last):
        File "...\venv\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 353, in <module>
          main()
        File "...\venv\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "...\venv\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "...\Temp\pip-build-env-hrplmjyh\overlay\Lib\site-packages\setuptools\build_meta.py", line 332, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "...\Temp\pip-build-env-hrplmjyh\overlay\Lib\site-packages\setuptools\build_meta.py", line 302, in _get_build_requires
          self.run_setup()
        File "...\Temp\pip-build-env-hrplmjyh\overlay\Lib\site-packages\setuptools\build_meta.py", line 318, in run_setup
          exec(code, locals())
        File "<string>", line 8, in <module>
      RuntimeError: uvloop does not support Windows at the moment
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

@joelvdavies joelvdavies requested a review from VKTB September 23, 2024 13:18
@joelvdavies joelvdavies merged commit 85790cb into develop Sep 23, 2024
1 check passed
@joelvdavies joelvdavies deleted the setup-monogo-db-and-s3-clients-#4 branch September 23, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config and FastAPI dependencies for MongoDB and S3 clients
2 participants