Limit attachment upload size #17 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelvdavies
changed the base branch from
develop
to
add-attachment-post-#11
joelvdavies
force-pushed
the
limit-attachment-upload-size-#17
branch
from
59dfed3 to
d8cb690
Compare
3 tasks
joelvdavies
force-pushed
the
add-attachment-post-#11
branch
from
2064e4d to
88ce418
Compare
VKTB
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Limits the attachment upload size by changing to using a POST request for uploads allowing specific conditions to be specified (see #17 comments for what happened when spoofing the content length in the header). The data returned is now not just an
upload_urlbut insteadupload_infowith both aurlandfieldsthat should be POSTed along with the file data.I have tried modifying the key in these fields and verified that it denies the request as it breaks the policy.
If testing with something like postman/insomnia you need to use a
form-databody with all thefieldsreturned by the/attachmentsPOST endpoint, and an additional onefilewith the actual file data. Internally the content boundary is also set by postman or in the e2e tests through using thefilesparameter in the requests module. I am not quite sure what that would translate to on the front end but I assume either the browser or uppy will do it.Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #17