Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for generating mock attachments #14 #43

Merged
merged 10 commits into from
Oct 22, 2024

Conversation

joelvdavies
Copy link
Collaborator

@joelvdavies joelvdavies commented Oct 14, 2024

Description

Adds a dev_cli script with a generate command that runs a script to generate mock attachments for testing similar to that found on ims-api. Made some changes to reduce the number of entities in ral-facilities/inventory-management-system-api#397 and to clean up the script a bit.

Notes

  • Changes the default port to 8002 - this avoids conflicts with ims-api that would otherwise occur when running the generation script (chose a gap of 2 in case 8001 was taken up by something else such as vscode would if it detects 8000 is already forwarded)

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Closes #14

@joelvdavies joelvdavies added the enhancement New feature or request label Oct 14, 2024
@joelvdavies joelvdavies self-assigned this Oct 14, 2024
Base automatically changed from add-primary-images-#31 to develop October 16, 2024 08:13
@joelvdavies joelvdavies requested a review from VKTB October 16, 2024 08:15
@joelvdavies joelvdavies marked this pull request as ready for review October 16, 2024 08:15
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (b369b97) to head (cc3a089).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #43   +/-   ##
========================================
  Coverage    98.70%   98.70%           
========================================
  Files           19       19           
  Lines          310      310           
========================================
  Hits           306      306           
  Misses           4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

VKTB
VKTB previously approved these changes Oct 22, 2024
README.md Outdated Show resolved Hide resolved
Co-authored-by: Viktor Bozhinov <45173816+VKTB@users.noreply.github.com>
@joelvdavies joelvdavies merged commit 9c1dbfb into develop Oct 22, 2024
3 checks passed
@joelvdavies joelvdavies deleted the add-attachment-generation-script-#14 branch October 22, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add script for populating attachments
3 participants