-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script for generating mock attachments #14 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelvdavies
force-pushed
the
add-attachment-generation-script-#14
branch
from
October 14, 2024 14:39
7ec5c8d
to
79536f0
Compare
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #43 +/- ##
========================================
Coverage 98.70% 98.70%
========================================
Files 19 19
Lines 310 310
========================================
Hits 306 306
Misses 4 4 ☔ View full report in Codecov by Sentry. |
VKTB
previously approved these changes
Oct 22, 2024
Co-authored-by: Viktor Bozhinov <45173816+VKTB@users.noreply.github.com>
VKTB
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
dev_cli
script with agenerate
command that runs a script to generate mock attachments for testing similar to that found on ims-api. Made some changes to reduce the number of entities in ral-facilities/inventory-management-system-api#397 and to clean up the script a bit.Notes
8002
- this avoids conflicts withims-api
that would otherwise occur when running the generation script (chose a gap of 2 in case 8001 was taken up by something else such as vscode would if it detects 8000 is already forwarded)Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #14