Prevent file extension and content type mismatch #82
+116
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #82 +/- ##
===========================================
+ Coverage 98.89% 99.30% +0.41%
===========================================
Files 21 19 -2
Lines 453 434 -19
===========================================
- Hits 448 431 -17
+ Misses 5 3 -2 ☔ View full report in Codecov by Sentry. |
asuresh-code
force-pushed
the
download-image-#81
branch
from
ce21dd1 to
17387e8
Compare
asuresh-code
force-pushed
the
download-image-#81
branch
from
17387e8 to
9e3d72c
Compare
asuresh-code
force-pushed
the
download-image-#81
branch
from
9e3d72c to
85efdeb
Compare
asuresh-code
force-pushed
the
download-image-#81
branch
from
2046bd5 to
716c6bf
Compare
joelvdavies
reviewed
Jan 13, 2025
asuresh-code
force-pushed
the
download-image-#81
branch
from
7a81600 to
4051351
Compare
asuresh-code
force-pushed
the
download-image-#81
branch
from
4051351 to
9825c64
Compare
joelvdavies
reviewed
Jan 14, 2025
|
One other thing could you perhaps update the names of this PR and the issue to reflect its new purpose of preventing invalid files/add the issue to the IMS project board please, just helps us find things again. |
asuresh-code
changed the title
rowan04
reviewed
Jan 16, 2025
| """ | ||
| Mocks repo & store methods appropriately to test the `create` service method. | ||
|
|
||
| :param image_post_metadata_data: Dictionary containing the image metadata data as would be required for an | ||
| `ImagePostMetadataSchema`. | ||
| :filename: Filename of the image. |
There was a problem hiding this comment.
Suggested change
| :filename: Filename of the image. | |
| :param filename: Filename of the image. |
Comment on lines
+334
to
+337
| Class the `ImageService` `update` method with the appropriate data from a prior call to `mock_update`. | ||
| while expecting an error to be raised. | ||
|
|
||
| :param error_type: Expected exception to be raised. |
There was a problem hiding this comment.
Suggested change
| Class the `ImageService` `update` method with the appropriate data from a prior call to `mock_update`. | |
| while expecting an error to be raised. | |
| :param error_type: Expected exception to be raised. | |
| Class the `ImageService` `update` method with the appropriate data from a prior call to `mock_update`, | |
| while expecting an error to be raised. | |
| :param image_id: ID of the image to be updated. | |
| :param error_type: Expected exception to be raised. |
| @@ -356,6 +394,20 @@ def test_update_primary(self): | |||
| self.call_update(image_id) | |||
| self.check_update_success() | |||
|
|
|||
| def test_update_with_file_extension_content_type_mismatch(self): | |||
| """Test updating filename to a mismatched file extension.""" | |||
There was a problem hiding this comment.
Suggested change
| """Test updating filename to a mismatched file extension.""" | |
| """Test updating filename to one with a mismatched file extension.""" |
|
This is also an issue on the attachments side - I have created an issue for it #96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #81 Implements Option 3 (Store File Extension w/ Filename) Makes Changes to the edit service layer, to ensure that file extension is preserved.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #81