Add support for HTTPS and hosting at arbitrary URL path #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assumes pong web server is behind a reverse proxy w/ TLS termination
Implemented via PONG_URL_PATH environment variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pong web server expects to be hosted at http://localhost:/
This PR adds support for running pong behind a reverse proxy w/ TLS termination, hosted at an arbitrary URL path (e.g., "/apps/pong/"). In particular, this allows pong to be hosted as a web app on the Open OnDemand platform, which reverse proxies to web apps at /[r]node/(host)/(port)(path): https://osc.github.io/ood-documentation/master/app-development/interactive/view.html?highlight=rnode#reverse-proxy .
@jnovembre used this in a recent workshop.