Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video container width at 100% on mobile #479

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

yileifeng
Copy link
Member

@yileifeng yileifeng commented Oct 1, 2024

Related Item(s)

Missed part for https://github.com/ramp4-pcar4/tcei-tmx-cwa-storylines/issues/23

Changes

  • [FIX] set video panel width to take up all possible space on mobile

Testing

Steps:

  1. Test "cumulative effects" video slide on mobile

This change is Reviewable

Copy link

github-actions bot commented Oct 1, 2024

Copy link
Member

@spencerwahl spencerwahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

@yileifeng yileifeng merged commit e555eb7 into ramp4-pcar4:main Oct 8, 2024
3 checks passed
@yileifeng yileifeng deleted the video-mobile branch October 8, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants