Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic panel enhancements #482

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented Oct 3, 2024

Related Item(s)

#480 #481

Changes

  • Added new dynamic panel property reversed: if true, the control slide will appear on the right side of the slide and the dynamic content will appear on the left. Defaults to false.
  • Added new property hideReturn: if true, the "Return" button will not appear. Defaults to false.
  • Added new property contentWidth: the width of the text slide will be set to this value if it is defined. This is capped out at the width of the screen in mobile view.
  • The return button and dynamic links will now take into consideration the height of the horizontal table of contents when scrolling.

Testing

Steps:

  1. Open the demo page.
  2. Play around with the dynamic slide (titled This slide is dynamic!) and ensure everything is working as normal.

This change is Reviewable

Copy link

github-actions bot commented Oct 3, 2024

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/fix-481/#/en/00000000-0000-0000-0000-000000000000

@spencerwahl
Copy link
Member

Checked into WCAG to make sure focusing the right panel before the left is OK.

In case this question gets brough up in the future; https://www.w3.org/WAI/WCAG21/Understanding/focus-order.html

"The focus order may not be identical to the programmatically determined reading order (see Success Criterion 1.3.2) as long as the user can still understand and operate the Web page."

The guideline seems most concerned about focus jumping around randomly which this doesn't do so we are OK 👍

Copy link
Member

@spencerwahl spencerwahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

@spencerwahl spencerwahl merged commit 28f35a1 into ramp4-pcar4:main Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants