Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix window resizing issues + horizontal ToC overlapping elements #484

Closed
wants to merge 1 commit into from

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented Oct 9, 2024

Related Item(s)

#443

Changes

  • When resizing the product, everything should now reposition and scale correctly instead of displaying a horizontal scrollbar.
  • Also fixes an issue where the horizontal table of contents would cover parts of the stickied content.

Testing

Steps:

  1. Open the demo page.
  2. Ensure everything is still positioned correctly, and that the right hand stickied content is nicely aligned at the top of the page under the header.
  3. Now, resize the window (not to mobile width just yet).
  4. Ensure there is no horizontal scrollbar. Check that everything has resized correctly, and that stickied content is still nicely aligned at the top of the page.
  5. Make the page mobile width. Do the same checks and make sure everything is nicely positioned.

This change is Reviewable

Copy link

github-actions bot commented Oct 9, 2024

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/fix-443/#/en/00000000-0000-0000-0000-000000000000

@RyanCoulsonCA
Copy link
Member Author

Still getting some resizing issues on the demo site, looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant