Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interactive-image imageid and title bugs #527

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

spencerwahl
Copy link
Member

@spencerwahl spencerwahl commented Jan 6, 2025

Related Issue(s)

Fixes for #525

Changes

  • Fixes missing = in imageId check which was overwriting every zone to use the first image
  • Fixes missing prose class causing title not having proper default styles

Testing

I didn't want to clutter the config with tests for these small changes so just check that the interactive image panel works as expected.


This change is Reviewable

@spencerwahl spencerwahl added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spencerwahl)


src/components/panels/interactive-image-panel.vue line 9 at r1 (raw file):

    >
        <div
            class="sticky prose max-w-none min-w-0 mb-5 mx-1 py-0 sm:py-5 z-40"

The prose class seems to be adding a top-margin and bottom-margin of 2em to the image element which is resulting in text to appear above it on mobile mode:

image.png

Copy link
Member Author

@spencerwahl spencerwahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA and @yileifeng)


src/components/panels/interactive-image-panel.vue line 9 at r1 (raw file):

Previously, RyanCoulsonCA (Ryan Coulson) wrote…

The prose class seems to be adding a top-margin and bottom-margin of 2em to the image element which is resulting in text to appear above it on mobile mode:

image.png

Good catch. Fixed that and a related title bug

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)

@yileifeng yileifeng merged commit 32f82b3 into ramp4-pcar4:main Jan 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants