-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix interactive-image imageid and title bugs #527
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/interactive-image/#/en/00000000-0000-0000-0000-000000000000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spencerwahl)
src/components/panels/interactive-image-panel.vue
line 9 at r1 (raw file):
> <div class="sticky prose max-w-none min-w-0 mb-5 mx-1 py-0 sm:py-5 z-40"
The prose
class seems to be adding a top-margin
and bottom-margin
of 2em to the image element which is resulting in text to appear above it on mobile mode:
9667a36
to
67f7649
Compare
67f7649
to
32b2fa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA and @yileifeng)
src/components/panels/interactive-image-panel.vue
line 9 at r1 (raw file):
Previously, RyanCoulsonCA (Ryan Coulson) wrote…
The
prose
class seems to be adding atop-margin
andbottom-margin
of 2em to the image element which is resulting in text to appear above it on mobile mode:
Good catch. Fixed that and a related title bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)
Related Issue(s)
Fixes for #525
Changes
=
in imageId check which was overwriting every zone to use the first imageprose
class causing title not having proper default stylesTesting
I didn't want to clutter the config with tests for these small changes so just check that the interactive image panel works as expected.
This change is