Fix highlighting for items not included in custom ToC #532
Conversation
|
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/custom-toc-highlight/#/en/00000000-0000-0000-0000-000000000000 |
|
Should the parent ToC item stay highlighted when viewing a subitem? Right now unless you open the list that contains the subitem it looks like there is no highlight happening. |
|
Not sure about this one, since in this case the subitem will be highlighted so this is mostly expected behavior to me. Do you mean we should keep the parent item highlighted at all times when we are viewing any of its subitem slides? In that case, both the sublist item and the parent item will be highlighted when having the dropdown open and viewing a subitem slide but this could work. |
Yeah, it allows the user to always know where they are in the ToC. I think it will also make sense to users if they see the parent and a subitem highlighted, they are at the subitem within that parent. |
yileifeng
force-pushed
the
custom-toc-highlight
branch
from
195315d to
4ac8094
Compare
There was a problem hiding this comment.
Makes sense, made this change now thanks 👍
Reviewable status: 0 of 5 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yileifeng)
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:
Related Item(s)
#520
Changes
"tableOfContents"for test product config to align with updated slidesTesting
Removed some slides from configuration, verify when navigating to these slides the table of contents still highlights the last section prior to the slide.
This change is