Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling support for non-Spring launching, documentation #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wdile
Copy link

@wdile wdile commented Jul 2, 2017

Why

I was experimenting with JBot and found it difficult to launch a bot in a non-spring based application

What

The changes (almost exclusively to the privacy of the fields) allow you to create the Bot object and launch it yourself without the assistance of Spring.

I apologize if you don't like the style of documentation, it isn't exactly my strong point.

@wdile wdile force-pushed the feature/enabling-separate-initiation branch from 2009aba to 392b445 Compare July 2, 2017 22:40
Signed-off-by: William Dunne <william@tutuka.com>
@wdile wdile force-pushed the feature/enabling-separate-initiation branch from 392b445 to 85b197d Compare July 2, 2017 22:47
@rampatra
Copy link
Owner

rampatra commented Jul 3, 2017

Thank you very much @wildunne for your time and work, I will keep this PR open so if someone wants to use JBot without spring-boot can follow your tips but unfortunately, I created this as a spring-boot library and I have planned to add many more features in the near future which uses spring. So I cannot merge your PR to master as of now. If later things change then for sure, I will merge it.

Hope that's okay with you!

@wdile
Copy link
Author

wdile commented Jul 3, 2017

Fine with me, I managed to get around all of this using reflection tricks, it just seems like an odd way for things to be built because it makes it difficult to build anything that will be used by more than one team (at least this is the case as far as I can see)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants