Skip to content

Commit

Permalink
Fix comments and update workflow to fail on error
Browse files Browse the repository at this point in the history
  • Loading branch information
nwmac committed Sep 30, 2024
1 parent 3b7e5d0 commit 4e6d2dd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,9 @@ jobs:
- name: Install packages
run: yarn install:ci

- name: Run check of all http links in the i18n files (broken lnk check)
- name: Run check of all http links in the i18n files (broken link check)
run: |
# Falure won't fail the job (remove -x when all current issues are fixed)
./scripts/check-i18n-links -x
./scripts/check-i18n-links
# coverage:
# runs-on: ubuntu-latest
Expand Down
8 changes: 3 additions & 5 deletions scripts/check-i18n-links
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@

/**
* This script reads and parses all of the source code files, reads the US English
* translation files and compares the two to identify referenced strings that
* do not have a corresponding translation.
* translation files, extracts all http/s links and checks for broken links.
*
* This script is used in the PR gate to ensure code is not added without the
* corresponding translations.
* This script is used in the PR gate to check for broken links.
*
*/

Expand Down Expand Up @@ -144,7 +142,7 @@ function loadI18nFiles(folder) {
...loadI18nFiles(filePath)
};
} else if (file === 'en-us.yaml') {
console.log(` ... ${ path.relative(base, filePath) }`);
console.log(` ... ${ path.relative(base, filePath) }`); // eslint-disable-line no-console

const translations = readAndParseTranslations(filePath);

Expand Down

0 comments on commit 4e6d2dd

Please sign in to comment.