Flag CSS which require manual fix

rancher · Sep 23, 2024 · 8319730 · 8319730
1 parent 3da7352
commit 8319730
Show file tree

Hide file tree

Showing 21 changed files with 46 additions and 23 deletions.
diff --git a/pkg/kubectl-explain/components/ExplainPanel.vue b/pkg/kubectl-explain/components/ExplainPanel.vue
@@ -190,7 +190,8 @@ export default {
   </div>
 </template>
 
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
   .main {
     overflow: auto;
   }
@@ -301,7 +302,8 @@ export default {
     }
   }
 </style>
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
   .markdown {
     :deep( ) {
       P {

diff --git a/pkg/rancher-components/src/components/StringList/StringList.vue b/pkg/rancher-components/src/components/StringList/StringList.vue
@@ -529,7 +529,8 @@ export default defineComponent({
   </div>
 </template>
 
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
 
 .string-list {
   display: flex;

diff --git a/shell/components/ButtonDropdown.vue b/shell/components/ButtonDropdown.vue
@@ -226,7 +226,8 @@ export default {
   </v-select>
 </template>
 
-<style lang='scss' scoped>
+<style lang='scss' scoped> 
+// TODO #11952: Correct deep statement
 .button-dropdown.btn-sm {
   :deep( > .vs__dropdown-toggle ) {
     .vs__actions {

diff --git a/shell/components/ChartReadme.vue b/shell/components/ChartReadme.vue
@@ -52,7 +52,8 @@ export default {
   </div>
 </template>
 
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
   .chart-readmes {
     & > h1 {
        border-top: var(--header-border-size) solid var(--header-border);

diff --git a/shell/components/DashboardMetrics.vue b/shell/components/DashboardMetrics.vue
@@ -98,7 +98,8 @@ export default {
   </div>
 </template>
 
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
 .dashboard-metrics {
   & :deep( ) {
     .external-link {

diff --git a/shell/components/ExplorerMembers.vue b/shell/components/ExplorerMembers.vue
@@ -405,7 +405,8 @@ export default {
   </div>
 </template>
 
-<style lang='scss' scoped>
+<style lang='scss' scoped> 
+// TODO #11952: Correct deep statement
 
 .role {
   align-items: center;

diff --git a/shell/components/ExplorerProjectsNamespaces.vue b/shell/components/ExplorerProjectsNamespaces.vue
@@ -501,7 +501,8 @@ export default {
     <MoveModal @moving="clearSelection" />
   </div>
 </template>
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
 .project-namespaces {
   & :deep( ) {
     .project-namespaces-table table {
@@ -568,7 +569,8 @@ export default {
   }
 }
 </style>
-<style lang="scss">
+<style lang="scss"> 
+// TODO #11952: Correct deep statement
   .psa-tooltip {
     // These could pop up a lot as the mouse moves around, keep them as small and unintrusive as possible
     // (easier to test with v-clean-tooltip="{ content: getPSA(row), autoHide: false, show: true }")

diff --git a/shell/components/Markdown.vue b/shell/components/Markdown.vue
@@ -76,7 +76,8 @@ export default {
   <Loading v-else />
 </template>
 
-<style lang="scss">
+<style lang="scss"> 
+// TODO #11952: Correct deep statement
 
 :deep( ) {
   P {

diff --git a/shell/components/auth/RoleDetailEdit.vue b/shell/components/auth/RoleDetailEdit.vue
@@ -797,7 +797,8 @@ export default {
   </CruResource>
 </template>
 
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
   .required {
     color: var(--error);
   }

diff --git a/shell/components/form/EnvVars.vue b/shell/components/form/EnvVars.vue
@@ -130,7 +130,8 @@ export default {
   </div>
 </template>
 
-<style lang='scss' scoped>
+<style lang='scss' scoped> 
+// TODO #11952: Correct deep statement
 .value-from :deep( ) {
   .v-select {
     height: 50px;

diff --git a/shell/components/form/InputWithSelect.vue b/shell/components/form/InputWithSelect.vue
@@ -198,7 +198,8 @@ export default {
   </div>
 </template>
 
-<style lang='scss' scoped>
+<style lang='scss' scoped> 
+// TODO #11952: Correct deep statement
 .input-container {
   display: flex;
 

diff --git a/shell/components/form/LabeledSelect.vue b/shell/components/form/LabeledSelect.vue
@@ -419,7 +419,8 @@ export default {
   </div>
 </template>
 
-<style lang='scss' scoped>
+<style lang='scss' scoped> 
+// TODO #11952: Correct deep statement
 
 .labeled-select {
   position: relative;

diff --git a/shell/components/form/NameNsDescription.vue b/shell/components/form/NameNsDescription.vue
@@ -505,7 +505,8 @@ export default {
   </div>
 </template>
 
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
 button {
   all: unset;
   height: 0;

diff --git a/shell/components/form/ServicePorts.vue b/shell/components/form/ServicePorts.vue
@@ -273,7 +273,8 @@ export default {
   </div>
 </template>
 
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
  $remove: 75;
   $checkbox: 75;
 

diff --git a/shell/components/formatter/ClusterLink.vue b/shell/components/formatter/ClusterLink.vue
@@ -84,7 +84,8 @@ export default {
   </span>
 </template>
 
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
   .cluster-link {
     display: flex;
     align-items: center;

diff --git a/shell/components/nav/Group.vue b/shell/components/nav/Group.vue
@@ -282,7 +282,8 @@ export default {
   </div>
 </template>
 
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
   .header {
     position: relative;
     cursor: pointer;

diff --git a/shell/components/nav/Header.vue b/shell/components/nav/Header.vue
@@ -779,7 +779,8 @@ export default {
   </header>
 </template>
 
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
   // It would be nice to grab this from `Group.vue`, but there's margin, padding and border, which is overkill to var
   $side-menu-group-padding-left: 16px;
 

diff --git a/shell/detail/autoscaling.horizontalpodautoscaler/index.vue b/shell/detail/autoscaling.horizontalpodautoscaler/index.vue
@@ -240,7 +240,8 @@ export default {
   </ResourceTabs>
 </template>
 
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
 .hpa-metrics-table {
   .info-box :deep( ) {
     background-color: var(--simple-box-bg);

diff --git a/shell/edit/logging-flow/index.vue b/shell/edit/logging-flow/index.vue
@@ -473,7 +473,8 @@ export default {
   />
 </template>
 
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
 :deep( ) {
   .icon-info {
     margin-top: -3px;

diff --git a/shell/edit/networking.k8s.io.ingress/RulePath.vue b/shell/edit/networking.k8s.io.ingress/RulePath.vue
@@ -180,7 +180,8 @@ export default {
     </button>
   </div>
 </template>
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
 $row-height: 40px;
 
 .labeled-input :deep(, :deep() .labeled-input ) {

diff --git a/shell/edit/provisioning.cattle.io.cluster/tabs/MachinePool.vue b/shell/edit/provisioning.cattle.io.cluster/tabs/MachinePool.vue
@@ -366,7 +366,8 @@ export default {
   </div>
 </template>
 
-<style lang="scss" scoped>
+<style lang="scss" scoped> 
+// TODO #11952: Correct deep statement
   .advanced :deep() >.vue-portal-target:empty,
   .advanced :deep( >.vue-portal-target:empty + .spacer ) {
     display: none;