From 9293d28b7ebe12c6d4ef8e9c40683dc4b951bf64 Mon Sep 17 00:00:00 2001
From: Alexandre Alves <alexandre.alves@suse.com>
Date: Thu, 24 Oct 2024 17:26:59 +0100
Subject: [PATCH] adapt saml logout logic to rely on info from public
 authprovider for SLO feature

---
 shell/components/nav/Header.vue | 21 +++++++++------------
 shell/pages/auth/logout.vue     | 16 +++++++---------
 2 files changed, 16 insertions(+), 21 deletions(-)

diff --git a/shell/components/nav/Header.vue b/shell/components/nav/Header.vue
index 9bdd8c6ab3a..e5ddeed8756 100644
--- a/shell/components/nav/Header.vue
+++ b/shell/components/nav/Header.vue
@@ -1,7 +1,7 @@
 <script>
 import { mapGetters } from 'vuex';
 import debounce from 'lodash/debounce';
-import { NORMAN, STEVE, MANAGEMENT } from '@shell/config/types';
+import { NORMAN, STEVE } from '@shell/config/types';
 import { ucFirst } from '@shell/utils/string';
 import { isAlternate, isMac } from '@shell/utils/platform';
 import Import from '@shell/components/Import';
@@ -20,7 +20,7 @@ import { ActionLocation, ExtensionPoint } from '@shell/core/types';
 import { getApplicableExtensionEnhancements } from '@shell/core/plugin-helpers';
 import IconOrSvg from '@shell/components/IconOrSvg';
 import { wait } from '@shell/utils/async';
-import { authProvidersInfo, parseAuthProvidersInfo } from '@shell/utils/auth';
+import { configType } from '@shell/models/management.cattle.io.authconfig';
 import HeaderPageActionMenu from './HeaderPageActionMenu.vue';
 
 export default {
@@ -48,7 +48,7 @@ export default {
 
   fetch() {
     // fetch needed data to check if any auth provider is enabled
-    authProvidersInfo(this.$store);
+    this.$store.dispatch('auth/getAuthProviders');
   },
 
   data() {
@@ -89,11 +89,10 @@ export default {
       'showTopLevelMenu'
     ]),
 
-    authProviderEnabled() {
-      const authProviders = this.$store.getters['management/all'](MANAGEMENT.AUTH_CONFIG);
-      const authInfo = parseAuthProvidersInfo(authProviders);
+    samlAuthProviderEnabled() {
+      const publicAuthProviders = this.$store.getters['rancher/all']('authProvider');
 
-      return authInfo.enabled?.[0] || {};
+      return publicAuthProviders.find((authProvider) => configType[authProvider.id] === 'saml') || {};
     },
 
     shouldShowSloLogoutModal() {
@@ -102,11 +101,9 @@ export default {
         return false;
       }
 
-      const {
-        logoutAllSupported, logoutAllEnabled, logoutAllForced, configType
-      } = this.authProviderEnabled;
+      const { logoutAllSupported, logoutAllEnabled, logoutAllForced } = this.samlAuthProviderEnabled;
 
-      return configType === 'saml' && logoutAllSupported && logoutAllEnabled && !logoutAllForced;
+      return logoutAllSupported && logoutAllEnabled && !logoutAllForced;
     },
 
     appName() {
@@ -260,7 +257,7 @@ export default {
     showSloModal() {
       this.$store.dispatch('management/promptModal', {
         component:      'SloDialog',
-        componentProps: { authProvider: this.authProviderEnabled },
+        componentProps: { authProvider: this.samlAuthProviderEnabled },
         modalWidth:     '500px'
       });
     },
diff --git a/shell/pages/auth/logout.vue b/shell/pages/auth/logout.vue
index cb9de7eca38..c8cb8059aad 100644
--- a/shell/pages/auth/logout.vue
+++ b/shell/pages/auth/logout.vue
@@ -1,21 +1,19 @@
 <script>
-import { authProvidersInfo } from '@shell/utils/auth';
+import { configType } from '@shell/models/management.cattle.io.authconfig';
 
 export default {
   async fetch() {
-    const authInfo = await authProvidersInfo(this.$store);
+    const publicAuthProviders = await this.$store.dispatch('auth/getAuthProviders');
 
-    if (authInfo.enabled?.length) {
-      const authProvider = authInfo.enabled[0];
+    const samlAuthProvider = publicAuthProviders.find((authProvider) => configType[authProvider.id] === 'saml');
 
-      const {
-        logoutAllSupported, logoutAllEnabled, logoutAllForced, configType
-      } = authProvider;
+    if (!!samlAuthProvider) {
+      const { logoutAllSupported, logoutAllEnabled, logoutAllForced } = samlAuthProvider;
 
-      if (configType === 'saml' && logoutAllSupported && logoutAllEnabled && logoutAllForced) {
+      if (logoutAllSupported && logoutAllEnabled && logoutAllForced) {
         // SAML - force SLO (logout from all apps)
         await this.$store.dispatch('auth/logout', {
-          force: true, slo: true, provider: authProvider
+          force: true, slo: true, provider: samlAuthProvider
         }, { root: true });
       } else {
         // simple logout