Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor shell/plugins/i18n.js plugin #10800

Closed
Tracked by #10774
rak-phillip opened this issue Apr 12, 2024 · 2 comments · Fixed by #10801
Closed
Tracked by #10774

Refactor shell/plugins/i18n.js plugin #10800

rak-phillip opened this issue Apr 12, 2024 · 2 comments · Fixed by #10801
Assignees
@rak-phillip
Labels
QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone
v2.9.0

Comments

@rak-phillip
Copy link
Member

rak-phillip commented Apr 12, 2024 •
edited by zube bot
Loading

Refactor to i18n plugin to use an install function. Using an install function will help us to properly manage our Vue instance as Rancher Dashboard migrates to Vue3.

#10774
@rak-phillip rak-phillip mentioned this issue Apr 12, 2024
Closed
1 task
@github-actions github-actions bot added [zube]: To Triage QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Apr 12, 2024
@rak-phillip rak-phillip changed the title shell/plugins/i18n.js Refactor shell/plugins/i18n.js plugin Apr 12, 2024
@rak-phillip rak-phillip self-assigned this Apr 12, 2024
@rak-phillip rak-phillip added this to the v2.9.0 milestone Apr 12, 2024
@rak-phillip rak-phillip mentioned this issue Apr 12, 2024
Merged
7 tasks
@izaac
Copy link
Contributor

izaac commented May 2, 2024

e2e coverage looks good and the use of POs are good to me.
@yonasberhe23

@izaac
Copy link
Contributor

izaac commented May 8, 2024

Moving as Done.

@izaac izaac closed this as completed May 8, 2024
@cnotv cnotv mentioned this issue Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rak-phillip rak-phillip

Labels
QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging a pull request may close this issue.

Refactor the i18n plugin to use an install function rak-phillip/dashboard
3 participants
@izaac @rak-phillip @gaktive