Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cluster list in burger menu having unnecessary horizontal scroll #12591

Merged
merged 5 commits into from
Nov 16, 2024

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Nov 12, 2024

Summary

Fixes #11809

Changed width setting so that it doesn't need scroller on smaller screens.
Tested on Chrome, Firefox and Safari

Occurred changes and/or fixed issues

N/A

Technical notes summary

N/A

Areas or cases that should be tested

Burger menu:

  • Check cluster list with burger menu with 1 cluster both open and collapsed. Try different window sizes.
  • Add more clusters (ie import custom clusters) until it requires virtual scroll in the side menu. Repeat step 1.
    No horizontal scroll should be visible, clusters should be able to get pinned, layout should seem reasonable.

Areas which could experience regressions

N/A

Screenshot/Video

https://github.com/user-attachments/assets/e69cff4c-0597-4750-96dc-2e5884c8fd77
https://github.com/user-attachments/assets/fc64477b-a471-408a-bcc2-1efcc2a42356

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@eva-vashkevich
Copy link
Member Author

eva-vashkevich commented Nov 14, 2024

Updated css.
Screenshot 2024-11-14 at 1 12 35 PM
Screenshot 2024-11-14 at 1 12 18 PM
Screenshot 2024-11-14 at 1 16 14 PM

@momesgin
Copy link
Member

Updated css. Screenshot 2024-11-14 at 1 12 35 PM Screenshot 2024-11-14 at 1 12 18 PM Screenshot 2024-11-14 at 1 16 14 PM

Interestingly I can't see the pins touch the edge of TopLevelMenu on my machine unlike your last screenshot, I tried changing the OS's scroll bar setting but still it doesn't happen. Personally I don't like the pins touching the edge, but at the end of the day that's up to the designers.

Besides that I found two issues after this change, tooltip position and pin icons distance from the edge

before:
image

after:
image

Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eva-vashkevich eva-vashkevich merged commit 907875f into rancher:master Nov 16, 2024
31 checks passed
@eva-vashkevich eva-vashkevich deleted the iss11809 branch November 16, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Burger Menu: Cluster List: Placement of pin cluster is incorrect, causes scroll bar
2 participants