add retry logic for failing user creation network request #10261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 12, 2024 10:00
richard-cox
approved these changes
Jan 12, 2024
yonasberhe23
pushed a commit
to yonasberhe23/dashboard
that referenced
this pull request
Jan 26, 2024
) * add retry logic for failing user creation network request * add failing network request to retry logic + remove commented code * fix lint issue * address scenario where global role binding fails and we need to delete the user created to retry --------- Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
yonasberhe23
pushed a commit
to yonasberhe23/dashboard
that referenced
this pull request
Jan 29, 2024
) * add retry logic for failing user creation network request * add failing network request to retry logic + remove commented code * fix lint issue * address scenario where global role binding fails and we need to delete the user created to retry --------- Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10260
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
This is a video, with a couple of changes on the code in order to visualise the fix:
Screen.Recording.2024-01-11.at.18.26.48.mov